Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shazam top tracks #79

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Shazam top tracks #79

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25070ae
set up api endpoint for fetching topCharts
Aadarsh805 Oct 7, 2022
daed5d5
fixed api endpoint
Aadarsh805 Oct 7, 2022
2a99546
made top charts to fetch dynamically using shazam api
Aadarsh805 Oct 7, 2022
da07f83
alright tracks are being fetch and rendered on topcharts
Aadarsh805 Oct 7, 2022
3d3dbdf
moved api key to env.local
Aadarsh805 Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/TopCharts/TopCharts.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ const TopCharts = ({ topCharts }) => {
<Image
src={chart?.images.coverart}
alt={chart?.title}
width={16}
height={16}
width='100%'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of width & height 100% we can use the layout="fill" and set the parent container "relative"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of width & height 100% we can use the layout="fill" and set the parent container "relative"

you should have changed it while merging, I'll change it in next commit

height='100%'
/>
</div>

Expand Down
2 changes: 1 addition & 1 deletion pages/Explore.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const Explore = () => {
try {
const res = await axios.get('api/top/charts');
const { data } = res;
setTopCharts(data.tracks);
setTopCharts(data.tracks)
} catch (error) {
console.log('yo', error);
}
Expand Down