Make impl Debug for Rwlock simpler #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
reviewed
Dec 4, 2023
lock_api/src/rwlock.rs
Outdated
| } | ||
| } | ||
| Some(guard) => d.field("data", &&*guard), | ||
| None => d.field("data", &format_args!("<locked>")), |
There was a problem hiding this comment.
format_args! is not needed here. field accepts any &dyn Debug which includes str.
There was a problem hiding this comment.
Without format_args!, the <locked> will be wrapped with quotes, e.g.: Rwlock { data: "<locked>" }
There was a problem hiding this comment.
Can you add a comment that explains this? It is not obvious from looking at the code.
Amanieu
reviewed
Dec 4, 2023
| .finish() | ||
| } | ||
| } | ||
| Some(guard) => d.field("data", &&*guard), |
There was a problem hiding this comment.
Is the &&* really needed here? Can this just be &*?
There was a problem hiding this comment.
T is ?Sized, which means &T cannot be coerced to &dyn Debug. That's why there is an additional &
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple improvement