Fix compilation on ARM based systems #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misleading name; the original intent was to ensure when writing out coordinates with a certain step size that the precision was large enough to accomodate the step (e.g. a step of .001 would need at least a precision of 3). Also rework the function so it is more accurate for values that are not exactly powers of 10.
(fix) the output precision of certain X step values in output ASCII data formats in some cases.
|
Build of the manual is still broken. 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 6.28.0.
This should fix the test failures on ARM systems observed in #1070 (I finally got access to an ARM system for testing). The problem was simple; the function that is supposed to detect the number of leading zeros in a floating point number fractional part wasn't properly protected against a value of 0 being passed to
log10(). On ARM systems this failure lead to bad precision values which in turn gave bad output to ASCII data files. This PR fixes the behavior.