-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize Drude particles, improve handling of lone pairs #1099
Conversation
… and checks for zero mass in distance/angle/dihedral/vector
… there is a parameter being passed in, use the passed in parameter.
Grr, python 😠 @hainm can you take a look? https://github.com/Amber-MD/cpptraj/actions/runs/10618137181/job/29432643446?pr=1099 I'm going to merge this stuff if everything else passes this seems like one of those "with some python versions it works, with some it fails" errors, i.e. the errors are not related to the changes in this PR. |
I will have a look next week, I will have an international flight.
Hai
…On Thu, Aug 29, 2024 at 10:50 PM Daniel R. Roe ***@***.***> wrote:
Grr, python 😠 @hainm <https://github.com/hainm> can you take a look?
https://github.com/Amber-MD/cpptraj/actions/runs/10618137181/job/29432643446?pr=1099
I'm going to merge this stuff if everything else passes this seems like
one of those "with some python versions it works, with some it fails"
errors, i.e. the errors are not related to the changes in this PR.
—
Reply to this email directly, view it on GitHub
<#1099 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB645K3GHM5BPMCLIPKBDLZT47N7AVCNFSM6AAAAABNKRKSG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJYGIYDMMJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@drroe It seems like a real issue instead of python thing. um. I don't know why yet. |
Version 6.29.0.
DR
.distance
,angle
,dihedral
, andvector
actions now check if the total mass of atoms in a mask is zero when center of mass is requested; this can happen when e.g. only lone pairs are selected.geom
keyword tovector
to enable vector calculation using geometric centers instead of center of mass (to get around the aforementioned zero mass problem).debye
keyword tovector dipole
to report dipole vector in units of Debye.bondparm
command for printing the bond parameter table.Adds a test for reading Charmm PSF files with Drude particles. Updates the manual.