Feature/eip 7702 #1262
Open
Feature/eip 7702 #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and verifyMessage
…7702 main.ts implementation
…n into feature/eip-7702
…which doesn't; a function to check whether the user has authrorized a network
…ate; bettet detection for 7702
borislav-itskov
temporarily deployed
to
tests
GitHub Actions
Inactive
borislav-itskov
temporarily deployed
to
tests
GitHub Actions
Inactive
borislav-itskov
temporarily deployed
to
tests
GitHub Actions
Inactive
borislav-itskov
temporarily deployed
to
tests
GitHub Actions
Inactive
borislav-itskov
temporarily deployed
to
tests
GitHub Actions
Inactive
superKalo
reviewed
Feb 14, 2025
| @@ -33,6 +33,7 @@ | |||
| "bip44-constants": "^128.0.0", | |||
| "ethereumjs-util": "^7.1.3", | |||
| "react": "^18.1.0", | |||
| "secp256k1": "^5.0.1", | |||
There was a problem hiding this comment.
Since this package is used in ambire-common (src/libs/keystoreSigner/keystoreSigner.ts), shouldn't we put this package as a "dependency" here? And then - the extension should not have this package installed separately?
superKalo
reviewed
Feb 14, 2025
| canSwitch(bundlerError: Error | null): boolean { | ||
| canSwitch(acc: Account, bundlerError: Error | null): boolean { | ||
| // no fallbacks for EOAs | ||
| if (!acc.creation) return false |
There was a problem hiding this comment.
Maybe isBasicAccount(acc, state)?
|
So far so good 👏 |
…de properties correct if 7702 eoa (no state override needed there); fix nonce in account state for 7702 eoas
…n into feature/eip-7702
borislav-itskov
had a problem deploying
to
tests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything necessary to enable eip-7702