Feature / Keystore Extra Entropy #1295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivshti
requested changes
Feb 11, 2025
|
|
||
| const hash = getBytes(keccak256(this.#entropyPool)) | ||
| const randomBytesGenerated = randomBytes(length) | ||
| // ensures non-deterministic final output |
There was a problem hiding this comment.
this comment is incorrect - not sure what you meant but it is deterministic - the same input will always generate the same output
| } | ||
|
|
||
| #collectSystemNoiseEntropy(): void { | ||
| const systemNoise = randomBytes(16) |
There was a problem hiding this comment.
that's not really system noise though
| } | ||
|
|
||
| addEntropy(newEntropy: Uint8Array): void { | ||
| const combined = new Uint8Array(this.#entropyPool.length + newEntropy.length) |
There was a problem hiding this comment.
is there a better way to concat?
| mainKey = { | ||
| key, | ||
| iv: randomBytes(16) |
There was a problem hiding this comment.
where do we take the extra entropy from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/AmbireTech/ambire-app/issues/1306