Create triggers for tables in unmigrated apps when run_syncdb is specified #113
Conversation
danifus
force-pushed
the
syncdb
branch
2 times, most recently
from
e6115c0 to
4970b1c
Compare
|
@danifus thanks so much! This is a great enhancement. Also thanks for fixing the bug that you found with the migrations. I put a reminder to come back to this PR this weekend to see if I can get it in. I'm assuming that you have a local project that uses syncdb for tests and tried it out locally? Thanks for all of the tests. I may need to push a few things to this branch since I just recently made some changes to CI (psycopg3 testing). But I should be good to release this and test it out more |
|
Great! Thanks! Yeah, I was working on a library package and it was a bit easier to iterate while developing without having to recreate the migrations between tests after updating the triggers. Happy to make any changes to the PR to make it compatible with your psycopg3 changes. |
… create missing triggers Django can create tables without migrations if an app is left 'unmigrated' (doesn't have a migrations package in the app) and the run_syncdb option is provided to the migrate command. This change allows triggers to be created in this manner. We override `DatabaseSchemaEditorMixin.create_model()` to detect missing triggers from one migration state to the next (or reverse if unapplying), and add them to the database if they're missing. This also has the side effect of recreating triggers when a migration that removed some triggers is unapplied, the triggers are now recreated.
|
Implemented these fixes with #130 and ensured you were the commit author. Thanks for these fixes! Will post back on the issues when they are deployed |
Implements #112
It creates the triggers in
DatabaseSchemaEditorMixin.create_modelby creating any triggers defined in the modelsMeta.triggersattribute. The triggers should only be created here if we're doing a 'run_syncdb' operation on an unmigrated app.create_modelis also called during a CreateTable migration operation too, but given the logic in MigrationAutodetectorMixin above, the initial state of the table used in theCreateTableoperation won't have anytriggersattribute yet. Thetriggersattibute only gets added to the model's migration state with anAddTriggeroperation after the initialCreateTableoperation.