Trigger ignore_others parameter addition #194
Conversation
|
Hey just wanted to give a heads up that I have this on my radar to review and get in this weekend. At first glance, this looks amazing though! Thank you so much - this has definitely been on my wishlist for pgtrigger |
| ), | ||
| } | self.kwargs | ||
|
|
||
| return self.func.format(**kwargs) |
There was a problem hiding this comment.
Func doesn't seem to be the optimal place for generating boilerplate wrapper SQL like this. For example, this is where triggers are wrapped with the ability to be ignored. I assumed that we would also generate this boilerplate in a similar way. Having a self.kwargs variable also strikes me as a hack.
Was there a reason behind overriding Func?
There was a problem hiding this comment.
Only that Func seemed to be only a wrapper for string formatting. This extends it to also provide custom context. See docs/ignoring_triggers.md:101
The reset_ignore template can very well be defined outside the Func
There was a problem hiding this comment.
About your example in compiler.py. I could not think of a way to wrap a user defined trigger body in such a way that resetting the _pgtrigger_ignore would always get executed. The user might return from any branch in their script.
The user would have to decide when to reset it
This introduces the
ignore_othersparameter inpgtrigger.Trigger.See discussion #190