Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use current AIRAC, changes/optimizations #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

b-faller
Copy link

@b-faller b-faller commented Jun 7, 2022

  • Always use the last AIRAC with "/latest/base/latest" path.
  • Use a less restrictive zoom to allow view of the airport layout.
  • Adjust minimum and maximum tile level to prevent fetching of
    unavailable tiles.
  • Add download policy for aero tiles as well, since I'm unsure if it is
    picked up.

It's a bit of a mess with quite some changes so feedback is encouraged but I had those changes lying around for some time. 🙂

- Always use the last AIRAC with "/latest/base/latest" path.
- Use a less restrictive zoom to allow view of the airport layout.
- Adjust minimum and maximum tile level to prevent fetching of
  unavailable tiles.
- Add download policy for aero tiles as well, since I'm unsure if it is
  picked up.
@AndreGeddert
Copy link
Contributor

Tested this out, works good. Didnt know about the /lastest/base/latest path. Thats very good.
14 days cache time seems reasonable, but maybe a bit too long if AIRACs come every month?
The zoom in is very usefull for ground layout! The zoom out is quite much out, but its ok.

@b-faller
Copy link
Author

b-faller commented Jun 7, 2022

14 days cache time seems reasonable, but maybe a bit too long if AIRACs come every month?

Could be changed for sure. Ideally we'd be able to flush the cache at an AIRAC expiry date but that's not possible AFAIK so it's a tradeoff how much load we want to put on their servers.

@jonaseberle
Copy link

Tested. Works good. Thank you.
I like the higher zoom range.

Copy link

@LouisTrinczek LouisTrinczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended

Merging this pull request will fix issue #18

@jonaseberle jonaseberle mentioned this pull request Sep 8, 2022
@mol-lux
Copy link

mol-lux commented Oct 9, 2022

Is there hope for this getting merged anytime soon? This fix works, but expecting everyone to dig this far down is... suboptimel :D

Pinging @AmbitiousPilots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants