Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create reward plugin #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: create reward plugin #3

wants to merge 2 commits into from

Conversation

Amit0617
Copy link
Owner

Resolves #46

Copy link

github-actions bot commented Oct 17, 2024

Unused exports (1)

Filename exports
src/handlers/contrib-reward.ts contributorReward

Copy link

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to post QA

manifest.json Outdated Show resolved Hide resolved
src/handlers/contrib-reward.ts Outdated Show resolved Hide resolved
src/handlers/contrib-reward.ts Outdated Show resolved Hide resolved
const body = payload.comment.body;

if (!body.match(/rewards/i)) {
logger.error(`Invalid use of slash command, use "/rewards".`, { body });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this entire conditional block's purpose.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SInce, I used hello-world.ts file as reference, I thought may be this would help in some error handling and just imitated as it is.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in the next commit.

.github/workflows/compute.yml Outdated Show resolved Hide resolved
@Amit0617 Amit0617 requested a review from 0x4007 November 1, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants