-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This pull request introduces a new feature that allows users to set the duration for meditation in seconds. The application now prompts users to input their desired meditation duration, which is then displayed in the app. #207
This pull request introduces a new feature that allows users to set the duration for meditation in seconds. The application now prompts users to input their desired meditation duration, which is then displayed in the app. #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
Please follow these guidelines for smooth collaboration:
- After completing a task, add your name and details to the Contributors Table/List.
- Attach relevant screenshots or videos of your contribution for transparency.
- Tasks are assigned on a first-come, first-served basis.
- Avoid spamming requests for already-assigned tasks.
- Respect the queue and wait for new tasks.
- Propose New Ideas: Discuss new features or suggestions in the "Ideas" channel before starting work.
Hi @Amna-Hassan04 , I have completed the integration of voice commands for the meditation feature as assigned. The implementation allows users to set a meditation duration through the Streamlit app, and upon starting the meditation session, it provides voice feedback on the duration. Please let me know if you have any feedback or if there are additional features you would like me to implement. Thank you! |
@imDarshanGK Add all the relevant screenshot / video showcasing your work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @imDarshanGK for setting the new feature, but for convenience kindly add the relevant pictures and videos on the working of the duration of mediation.
@Amna-Hassan04 look at the provided images, it looks all the requirements are fulfilled and if you feel the same way merge this pr asap. |
yes @zoobiasyed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
firstly this code is not integrated with the app, u have just made a simple steramlit paeg and written yoru code on it, u havent even edited anything with the original apps code. and someone else has already implemented this feature in which time is being tracked for the meditation and a bar is showing it
#177
Changes Made
How to Test
streamlit run serenifi_app.py
.Future Improvements
Please review the changes and let me know if any adjustments are needed!
@Amna-Hassan04