forked from kata-containers/kata-containers
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kata deploy ppc64le #2
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-devmapper-tests-follow-up-1 ci: k8s: Fix typo in run-k8s-tests-on-garm.yaml
…pstream_upcall_feature Dragonball: optimize the placement of dbs-upcall features
This PR replaces the ubuntu image for one which has TensorFlow optimized for kata metrics. Fixes kata-containers#7866 Signed-off-by: Gabriela Cervantes <[email protected]>
…e_initialization metrics: re-enable memory-usage initialization step
`wait` waits for a job to complete, not a number of seconds. Not sure how I got that wrong in the first place, but it's what it's. Fixes: kata-containers#6542 Signed-off-by: Fabiano Fidêncio <[email protected]>
Otherwise the /etc/rancher/k3s/k3s.yaml is not readable by other users than root. As --write-config-mode is being passed, and that's an option that has to be passed to the `server`, -s is also added to the command line. Signed-off-by: Fabiano Fidêncio <[email protected]>
Let's download the vanilla kubectl binary into `/usr/bin/`, as we need to avoid hitting issues like: ```sh error: open /etc/rancher/k3s/k3s.yaml.lock: permission denied ``` The issue basically happens because k3s links `/usr/local/bin/kubectl` to `/usr/local/bin/k3s`, and that does extra stuff that vanilla `kubectl` doesn't do. Also, in order to properly use the k3s.yaml config with the vanilla kubectl, we're copying it to ~/.kube/config. Signed-off-by: Fabiano Fidêncio <[email protected]>
It should be plenty, and worked well in local tests. Signed-off-by: Fabiano Fidêncio <[email protected]>
As we were using `tee` without the `-a` (or `--apend`) aptton, the containerd config would be overwritten, leading to a NotReady state of the Node. Signed-off-by: Fabiano Fidêncio <[email protected]>
This PR changes the order in which the FIO test first cleans the environment and then checks if the environment is indeed clean. Fixes: kata-containers#7869 Signed-off-by: David Esparza <[email protected]>
Let's put a 1 minute sleep, just to make sure everything is back up again. Signed-off-by: Fabiano Fidêncio <[email protected]>
GARM runners do not come with the whole set of tools we need, or are used to when it comes to the GHA runners, so we need to manually install bats on those. Signed-off-by: Fabiano Fidêncio <[email protected]>
So we have a better control on which flavour of kubernetes kata-deploy is expected to be targetting. Signed-off-by: Fabiano Fidêncio <[email protected]>
We've been using the `kata-deploy-tdx` target as that also uses k3s as base, but it's better to just have a specific garm target. Signed-off-by: Fabiano Fidêncio <[email protected]>
That's what we've been using as part of Jenkins, so let's ensure things will work as they did before, and only after that consider upgrading the base OS used for the tests. Signed-off-by: Fabiano Fidêncio <[email protected]>
…s-devmapper-tests-follow-up-2 ci: k8s: Second round of fix-ups with the devmapper CI
The tests are failing to finish as the argument is invalid. Fixes: kata-containers#6542 Signed-off-by: Fabiano Fidêncio <[email protected]>
Let's keep both checks for now, but in the future we'll be able to remove the check for "firecracker", as the hypervisor name used as part of the GitHub Actions has to match what's used as part of the kata-deploy stuff, which is `fc` (as in `kata-fc for the runtime class) instead of `firecracker`. Signed-off-by: Fabiano Fidêncio <[email protected]>
There's absolutely no need to have the skip check as part of the test itself when it's already done as part of the setup function. We're only touching the files here that were touched in the previous commit. Signed-off-by: Fabiano Fidêncio <[email protected]>
The test is failing, and an issue has been opened to track it. For now, let's skip it. Issue: kata-containers#7873 Signed-off-by: Fabiano Fidêncio <[email protected]>
…s-devmapper-tests-follow-up-3 ci: k8s: Add clean-up-garm argument for gha-run.sh
This will make our image smaller, and still ensure it's multi-arch support. Fixes: kata-containers#7861 Signed-off-by: Fabiano Fidêncio <[email protected]>
Just a small change to improve the readability of modules before the actual changes. Signed-off-by: Beraldo Leal <[email protected]>
Currently, if GOPATH is not set, errors will raise since protoc is using GOPATH to find packages. Signed-off-by: Beraldo Leal <[email protected]>
The definitions are already specified in the .proto files using the go_package option. Centralizing them in one location reduces the potential for errors and simplifies the script. Signed-off-by: Beraldo Leal <[email protected]>
Currently, the script searches for .proto files within $GOPATH/. Consequently, modifications to a definition file in the current working directory won't influence the output .pb.go if the directory is outside of $GOPATH. For developers, it's more intuitive to alter the local codebase than the version stored in $GOPATH. With this modification, the generated .pb.go files will be relative to the current working directory, removing the need to clone this project under $GOPATH/src/github.com/kata-containers. Signed-off-by: Beraldo Leal <[email protected]>
import_path is used as the default package when no input files specify go_package. However, all the files we are currently building already have a go_package definition, making this behavior both redundant and error-prone. Additionally, one of our files (types.pb.go) resides outside the grpc directory, indicating that it's indeed ignored but also inconsistent. Signed-off-by: Beraldo Leal <[email protected]>
There is no reference to PROTO_FILE and this is not working. Also we are not inside a Makefile, so makes sense to adapt the usage to reflect the script instead of a make command. Signed-off-by: Beraldo Leal <[email protected]>
gogo.nullable is the main gogo.protobuf' feature used here. Since we are trying to remove gogo.protobuf, the first reasonable step seems to be remove this feature. This is a core update, and it will change how the structs are defined. I could spot only a few places using those structs, based on make check/build. Fixes kata-containers#7723. Signed-off-by: Beraldo Leal <[email protected]>
This syntax belongs to the legacy C virtiofsd implementation that we don't support anymore since kata-containers 3.1.3 because of other API breaking changes. People have been warned to switch from "none" to "never" since kata-containers 2.5.2. Let's officially do that. The compat code that would convert "none" to "never" isn't needed anymore. Just drop it. Fixes kata-containers#7864 Signed-off-by: Greg Kurz <[email protected]>
This is based on official CRI-O documentations[0] and right now we're making this specific to Ubuntu as that's what we have as runners. We may want to expand this in the future, but we're good for now. [0]: https://github.com/cri-o/cri-o/blob/main/install.md#apt-based-operating-systems Signed-off-by: Fabiano Fidêncio <[email protected]>
Let's make sure we'll also be testing k8s using CRI-O. For now, we'll only be running the CRI-O test with QEMU. Once it becomes stable we can expand this to other Hypervisors as well. Fixes: kata-containers#8005 Signed-off-by: Fabiano Fidêncio <[email protected]>
Otherwise we'll face the following error: ``` Failed to enable unit: Interactive authentication required. ``` Signed-off-by: Fabiano Fidêncio <[email protected]>
opa_linux_amd64_static 38M => 27M kata-agent 30M => 23M ls -alh opa_linux_amd64_static -rw-rw-r-- 1 arron arron 38M Jul 28 01:59 opa_linux_amd64_static ➜ kata-containers git:(main) ✗ strip opa_linux_amd64_static ➜ kata-containers git:(main) ✗ ls -alh opa_linux_amd64_static -rw-rw-r-- 1 arron arron 27M Sep 20 16:12 opa_linux_amd64_static ls -alh ./usr/bin/kata-agent -rwxr-xr-x. 1 root root 30M Jul 30 23:41 ./usr/bin/kata-agent ls -alh ./usr/bin/kata-agent -rwxr-xr-x. 1 root root 23M Sep 20 16:13 ./usr/bin/kata-agent Fixes: kata-containers#8011 Signed-off-by: Wang, Arron <[email protected]>
…ed-spaces runtime: support kernel params including spaces
…ith-crio-part-0 ci: k8s: Also run tests with CRI-O
The test has been added to the repo, but we have to also add it to the list of jobs to be executed. Fixes: kata-containers#8005 Signed-off-by: Fabiano Fidêncio <[email protected]>
Seems like the static checks are failing due the missing of the hunspell package this PR fixes that. Fixes kata-containers#8019 Signed-off-by: Gabriela Cervantes <[email protected]>
protocol: remove gogoprotobuff tests
…ith-crio-part-1 ci: Actually enable the CRI-O tests
Fixes: kata-containers#8027 Signed-off-by: Chris Porter <[email protected]>
This will allow us to easily test failures and fixes on that workflows. Fixes: kata-containers#8031 Signed-off-by: Fabiano Fidêncio <[email protected]>
…ush-after-build-be-trigger-by-workflow-dispatch ci: Trigger payload-after-push on workflow_dispatch
Clh suports direct i/o for disks. It doesn't offer any support for noflush, removed passing of option to cloud-hypervisor internal config Fixes: kata-containers#7798 Signed-off-by: Alexandru Matei <[email protected]>
Firecracker supports noflush semantic via Unsafe cache type. There is no support for direct i/o, remove it from config file Fixes: kata-containers#7823 Signed-off-by: Alexandru Matei <[email protected]>
This PR enables the latency test for gha run script for kata metrics. Fixes kata-containers#8037 Signed-off-by: Gabriela Cervantes <[email protected]>
This PR adds the latency benchmark for gha for kata metrics. Signed-off-by: Gabriela Cervantes <[email protected]>
gha: Install hunspell for static checks
clh: Direct IO support for block devices
To avoid the failure of not finding pandoc command this PR adds that package as a dependency for static checks. Fixes kata-containers#8041 Signed-off-by: Gabriela Cervantes <[email protected]>
feat(runtime-rs): introduce huge page mode to select VM RAM's backend
…-image-build-asset-is-failing-oras ci: rootfs-image build-asset is failing
The permissions on .docker/buildx/activity/default are regularly broken by us passing docker.sock + $HOME/.docker to a container running as root and then using buildx inside. Fixup ownership before executing docker commands. Fixes: kata-containers#8027 Signed-off-by: Jeremi Piotrowski <[email protected]>
gha: Add pandoc as a dependency for static checks
osbuild: Reduce guest components binary size with strip
…ork-clh runtime-rs: Add network support for cloud-hypervisor
local-build: Fix .docker ownership before build-payload
metrics: Enable latency test in gha run script
Signed-off-by: Amulyam24 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.