Update mod to 1.20.1

[TheBluekr]

I've done a quick attempt to update the code to run under 1.20.1
Done bit of a poor job in my opinion on my end but I don't have any prior experience in Java. It seems to run under Fabric, I haven't tested Forge at all.

[TheBluekr]

Forgot to specify that this would close #50 #51 #52
Would it be possible to get this reviewed, and if everything is fine, merged?

[CtrlAltcouk]

Hey @TheBluekr
Do you have a a working verion of the jar, would love to test it on my frabric server.

[FlameFire26]

Fabric version threw 100+ errors when building jar.
In files NoEnchantCapFabric.java and FabricPlatformHelper.java have several problems.

Forge version can build jar, but I haven't try it in game cause my game is 1.20.1 Fabric.

[TheBluekr]

Hey @TheBluekr
Do you have a a working verion of the jar, would love to test it on my frabric server.

Sorry I haven't gotten back, I'll do it later when I have access to the file I got.

Fabric version threw 100+ errors when building jar.
In files NoEnchantCapFabric.java and FabricPlatformHelper.java have several problems.

Forge version can build jar, but I haven't try it in game cause my game is 1.20.1 Fabric.

Did you use the files on my branch or the repo branch? I've managed to compile it after trying to fix the errors for a few hours.

[FlameFire26]

Yep, I was using your code to do that.
Most error say that some type (ex. net.minecraft.resources.ResourceLocation) is indirectly referenced from required type net.fabricmc.fabric.api.gamerule.v1.CustomGameRuleCategory and net.fabricmc.fabric.api.command.v2.CommandRegistrationCallback.
Another is The import net.minecraft.world.GameRules cannot be resolved.

The Fabric folder's Last commit message is still 1.19.3.

[TheBluekr]

Yep, I was using your code to do that.
Most error say that some type (ex. net.minecraft.resources.ResourceLocation) is indirectly referenced from required type net.fabricmc.fabric.api.gamerule.v1.CustomGameRuleCategory and net.fabricmc.fabric.api.command.v2.CommandRegistrationCallback.
Another is The import net.minecraft.world.GameRules cannot be resolved.

The Fabric folder's Last commit message is still 1.19.3.

Might be I didn't include the latest Fabric in the commit and just committed the code itself. I'll take a look next week once I'm more fully available.

[FlameFire26]

My friend had introduced another mod NoExpensive to me.
It's newest version add a featrue that similar to this mod. You can have a look.

[CtrlAltcouk]

Sorry I haven't gotten back, I'll do it later when I have access to the file I got.

Hey man did you get chance to upload the file

[TheBluekr]

Sorry I haven't gotten back, I'll do it later when I have access to the file I got.

Hey man did you get chance to upload the file

Hi, I've just got back home and with that to the files.
I've uploaded the jar to Discord. Generally I would recommend compiling the jar yourself rather though so you can validate it doesn't contain anything malicious. https://cdn.discordapp.com/attachments/707948506106822757/1140758351538561094/noenchantcap-fabric-1.20.1-2.2.6.jar
I will have to check though why FlameFire26 had issues with compiling.

[CtrlAltcouk]

Sorry I haven't gotten back, I'll do it later when I have access to the file I got.

Hey man did you get chance to upload the file

Hi, I've just got back home and with that to the files. I've uploaded the jar to Discord. Generally I would recommend compiling the jar yourself rather though so you can validate it doesn't contain anything malicious. https://cdn.discordapp.com/attachments/707948506106822757/1140758351538561094/noenchantcap-fabric-1.20.1-2.2.6.jar I will have to check though why FlameFire26 had issues with compiling.

Thank you, its dosent crash anymore but im not able to go above vanilla enchances

[KyRoZzZ-Ms]

Sorry I haven't gotten back, I'll do it later when I have access to the file I got.

Hey man did you get chance to upload the file

Hi, I've just got back home and with that to the files. I've uploaded the jar to Discord. Generally I would recommend compiling the jar yourself rather though so you can validate it doesn't contain anything malicious. https://cdn.discordapp.com/attachments/707948506106822757/1140758351538561094/noenchantcap-fabric-1.20.1-2.2.6.jar I will have to check though why FlameFire26 had issues with compiling.

Thank you, its dosent crash anymore but im not able to go above vanilla enchances

just do /gamerule noenchantcap:uncapped_anvils true

[Batimius]

I compiled and tested it in-game. Although I didn't stress-test it, it seemed to work without any crashes. The changes seem like corrections for the new version of Forge. It honestly looks good and ready to commit.

[EdjcJR]

Can help develop the forge version?

[memphismc]

you're a fucking godsend, thank you so much for this

[memphismc]

I've done a quick attempt to update the code to run under 1.20.1 Done bit of a poor job in my opinion on my end but I don't have any prior experience in Java. It seems to run under Fabric, I haven't tested Forge at all.

bit of a problem, though i have no idea if this is a feature or a bug
the gamerule "uncapped_anvils" is still on despite it being false
im assuming this feature means removing the cap of anvil levels which i dont want, so thats why i have it to false (set to false as default anyway)

it still uncaps the anvil even if its set to false, making levels above 40 take an insane amount of your levels if not all of your levels with fair charged experience

[lenamerkli]

Sorry I haven't gotten back, I'll do it later when I have access to the file I got.

Hey man did you get chance to upload the file

Hi, I've just got back home and with that to the files. I've uploaded the jar to Discord. Generally I would recommend compiling the jar yourself rather though so you can validate it doesn't contain anything malicious. https://cdn.discordapp.com/attachments/707948506106822757/1140758351538561094/noenchantcap-fabric-1.20.1-2.2.6.jar I will have to check though why FlameFire26 had issues with compiling.

I also have problems with compiling locally (fabric). The discord attachment expired and is no longer available. I operate a modded server and we would like to update from 1.19.2 to 1.20.1 (no other versions due to compatibility issues in other mods).

[TheBluekr]

I also have problems with compiling locally (fabric). The discord attachment expired and is no longer available. I operate a modded server and we would like to update from 1.19.2 to 1.20.1 (no other versions due to compatibility issues in other mods).

Yea this was why I wasn't in favor of having the file hosted on Discord due to its changes with how files are hosted. It would be great if there was a way to make the file available as a "release" but that depends on the author of this repo who doesn't seem as active.
I can try reuploading later once I have access to my environment with the necessary jar. Insert usual comment about running jars from sources you don't know.

[TheBluekr]

Since the Discord link expired again, here is a Drive link:
https://drive.google.com/file/d/1CZxG0eNqOne5hn1k6wwkP37oulEi74yI/view?usp=sharing

Don't have high hopes for me trying to port this again to newer versions as I really lack the experience in Java and Fabric modding.

[Fundryi]

No 1.20.1 Forger version available?