Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix culling (again) #66

Merged
merged 1 commit into from
Sep 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ yarn_mappings=1.21+build.9
loader_version=0.15.11

# Mod Properties
mod_version=2.0.15
mod_version=2.0.15.1
maven_group=amymialee
archives_base_name=visiblebarriers

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public abstract class ClientBarrierBlockMixin extends BlockMixin {
@Override
public void visibleBarriers$isSideInvisible(BlockState state, BlockState stateFrom, Direction direction, CallbackInfoReturnable<Boolean> cir) {
if (VisibleBarriers.isVisibilityEnabled() || VisibleBarriers.areBarriersEnabled()) {
cir.setReturnValue(stateFrom.isOpaque() || stateFrom.getBlock() == state.getBlock());
cir.setReturnValue(stateFrom.isOpaqueFullCube(null, null) || stateFrom.getBlock() == state.getBlock());
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public abstract class LightBlockMixin extends BlockMixin {
@Override
public void visibleBarriers$isSideInvisible(BlockState state, BlockState stateFrom, Direction direction, CallbackInfoReturnable<Boolean> cir) {
if (VisibleBarriers.isVisibilityEnabled() || VisibleBarriers.areLightsEnabled()) {
cir.setReturnValue(stateFrom.isOpaque() || stateFrom.getBlock() == state.getBlock());
cir.setReturnValue(stateFrom.isOpaqueFullCube(null, null) || stateFrom.getBlock() == state.getBlock());
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/fabric.mod.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"schemaVersion": 1,
"id": "visiblebarriers",
"version": "${version}",
"accessWidener" : "visiblebarriers.accesswidener",
"accessWidener": "visiblebarriers.accesswidener",
"name": "Visible Barriers",
"description": "Various tools for Minecraft Mapmaking.",
"authors": [
Expand Down