Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added config menu using modmenu and cloth_config lib #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GaeaKat
Copy link

@GaeaKat GaeaKat commented Oct 6, 2024

This adds a config menu, using ModMenu and ClothConfig.

The resulting menu looks like the following:
Screenshot 2024-10-06 at 2 49 46 AM

@GaeaKat
Copy link
Author

GaeaKat commented Oct 6, 2024

This is to hopefully add towards #69

@AmyMialee
Copy link
Collaborator

does this make cloth a required dependency? I would rather avoid that

@GaeaKat
Copy link
Author

GaeaKat commented Oct 6, 2024

does this make cloth a required dependency? I would rather avoid that

Only when modmenu is present. When it is not present, it runs fine without it in the modlist

@AmyMialee
Copy link
Collaborator

basically every pack has modmenu though?

@GaeaKat
Copy link
Author

GaeaKat commented Oct 6, 2024

basically every pack has modmenu though?

Fair, though I don't see many that have one without the other either. But sorry if the PR did it in a way that wasn't appropriate then! :)

@GaeaKat
Copy link
Author

GaeaKat commented Oct 6, 2024

Would it be prefered if I made it with a custom config screen instead? I used cloth as I thought it was a pretty standard library for inclusion, and such.

@AmyMialee
Copy link
Collaborator

I usually use something like midnight config or a custom thing just to avoid needing a library
Smaller mapmaking packs are less likely to already have cloth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants