[PKG-1649] line_profiler 4.0.3 #2

skupr-anaconda · 2023-05-08T12:21:25Z

Jira ticket: PKG-521

The upstream data:
Changelog: https://github.com/pyutils/line_profiler/blob/v4.0.3/CHANGELOG.rst
Diff between the latest and previous upstream releases
License:

Actions:

Fix MACOS version on osx-64 to fix error: use of undeclared identifier 'CLOCK_MONOTONIC', see macOS build error on 4.0.0 : undeclared identifier 'CLOCK_MONOTONIC' pyutils/line_profiler#185
Update script: add env variables, update pip install
Use ninja in build
Add pinnings in host, add missing wheel
Add pip check
Remove the test command: python -m line_profiler --help
Update home, doc & dev urls
Update license: add PSF-2.0 for line_profiler/timers.c
Add license_family

Notes:
*

Additional info:

Package's statistics

Priority 476 | effort: | Category: python | subcategory: github | pkg_type: "gh_org=pyutils;gh_repo=line_profiler"
Outdated platforms: 1
Latest version: 4.0.3
Release on PyPi:
- version: 4.0.3
- date: 2023-03-04T00:36:34
PyPi history
Popularity:
- 3 months downloads: 13
- All time: 385469 downloads - line_profiler 4.0.2 A module for monitoring memory usage of a python program

Other checks:

- Check the pinnings
- Verify that the 'build_number' is correct
- has 'setuptools'
- Verify if the package needs 'wheel'
- 'pip' in test
- Verify the test section
- Verify if the package is 'architecture specific'
- Verify that private modules are not mentioned in the recipe For example: (_private_module)
- license_file: LICENSE.txt is present
- License family is present
- License: BSD
- License is 'spdx' compliant

Check if the license identifier has correct name from the SPDX License List

Identifier
0BSD
BSD-1-Clause
BSD-2-Clause
BSD-2-Clause-Patent
BSD-2-Clause-Views
BSD-3-Clause
BSD-3-Clause-Attribution
BSD-3-Clause-Clear
BSD-3-Clause-LBNL
BSD-3-Clause-Modification
BSD-3-Clause-No-Military-License
BSD-3-Clause-No-Nuclear-License
BSD-3-Clause-No-Nuclear-License-2014
BSD-3-Clause-No-Nuclear-Warranty
BSD-3-Clause-Open-MPI
BSD-4-Clause
BSD-4-Clause-Shortened
BSD-4-Clause-UC
BSD-4.3RENO
BSD-4.3TAHOE
BSD-Advertising-Acknowledgement
BSD-Attribution-HPND-disclaimer
BSD-Protection
BSD-Source-Code
FreeBSD-DOC

Check dependency issues:

../aggregate/line_profiler-feedstock/recipe/meta.yaml Dependencies: ['ipython >=0.13', 'python', 'setuptools', 'scikit-build', 'cython']

noarch:

py3.8: No issues found
py3.9: No issues found
py3.10: No issues found
py3.11: No issues found

linux-64:

py3.8: No issues found
py3.9: No issues found
py3.10: No issues found
py3.11: No issues found

linux-ppc64le:

py3.8: No issues found
py3.9: No issues found
py3.10: No issues found
py3.11: No issues found

linux-s390x:

py3.8: No issues found
py3.9: No issues found
py3.10: No issues found
py3.11: No issues found

osx-64:

py3.8: No issues found
py3.9: No issues found
py3.10: No issues found
py3.11: No issues found

osx-arm64:

py3.8: No issues found
py3.9: No issues found
py3.10: No issues found
py3.11: No issues found

win-64:

py3.8: No issues found
py3.9: No issues found
py3.10: No issues found
py3.11: No issues found

**Other:**

Checking 'line_profiler' recipe... Undefined jinja expressions: - compiler --- Build Requirements --- �[91m -- jinja directive (compiler?) -- �[0m cmake: main make: main --- Host Requirements --- setuptools: main cython: main scikit-build: main

https://repo.anaconda.com/pkgs/main/noarch
https://repo.anaconda.com/pkgs/main/linux-64
line_profiler-3.3.1-py310hd09550d_0.tar.bz2
line_profiler-3.3.1-py37hd09550d_0.tar.bz2
line_profiler-3.3.1-py38hd09550d_0.tar.bz2
line_profiler-3.3.1-py39hd09550d_0.tar.bz2
https://repo.anaconda.com/pkgs/main/linux-ppc64le
line_profiler-3.3.1-py37h66086b3_0.tar.bz2
line_profiler-3.3.1-py39h66086b3_0.tar.bz2
line_profiler-3.3.1-py38h66086b3_0.tar.bz2
line_profiler-3.3.1-py310h66086b3_0.tar.bz2
https://repo.anaconda.com/pkgs/main/linux-aarch64/
line_profiler-3.3.1-py310h59a28a9_0.tar.bz2
line_profiler-3.3.1-py39h59a28a9_0.tar.bz2
line_profiler-3.3.1-py37h59a28a9_0.tar.bz2
line_profiler-3.3.1-py38h59a28a9_0.tar.bz2
https://repo.anaconda.com/pkgs/main/linux-s390x/
https://repo.anaconda.com/pkgs/main/osx-64
line_profiler-3.3.1-py38haf03e11_0.tar.bz2
line_profiler-3.3.1-py39haf03e11_0.tar.bz2
line_profiler-3.3.1-py310haf03e11_0.tar.bz2
line_profiler-3.3.1-py37haf03e11_0.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-arm64/
line_profiler-3.3.1-py38h525c30c_0.tar.bz2
line_profiler-3.3.1-py39h525c30c_0.tar.bz2
line_profiler-3.3.1-py310h525c30c_0.tar.bz2
https://repo.anaconda.com/pkgs/main/win-64
line_profiler-3.3.1-py39h59b6b97_0.tar.bz2
line_profiler-3.3.1-py38h59b6b97_0.tar.bz2
line_profiler-3.3.1-py37h59b6b97_0.tar.bz2

Package Build Score: 15

Links:

Updating the recipe:
If the recipe needs additional modification the update branch can be modified. Note that the PR diffs are not updated with these changes.

git clone -b 4.0.3 [email protected]:AnacondaRecipes/line_profiler-feedstock.git

anaconda-pkg-build · 2023-05-08T12:22:25Z

Linter check found the following problems:

The following problems have been found:

ERROR: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:29: cython_needs_compiler: Cython generates C code, which will need to be compiled
ERROR: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:34: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:47: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:51: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: 0BSD
INFO: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:57: invalid_url: https://pypi.python.org/pypi/line_profiler : URL domain redirect pypi.python.org -> pypi.org
WARNING: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:59: documentation_overspecified: Using doc_url and doc_source_url is overspecified
ERROR: /tmp/abs_3a3ijaccde/clone/recipe/meta.yaml:59: missing_license_family: The recipe is missing the about/license_family key.
Errors were found

anaconda-pkg-build · 2023-05-08T12:34:57Z

Linter check found the following problems:

The following problems have been found:

ERROR: /tmp/abs_acayw_m6j4/clone/recipe/meta.yaml:29: cython_needs_compiler: Cython generates C code, which will need to be compiled
Errors were found

anaconda-pkg-build · 2023-05-08T12:42:14Z

Linter check found the following problems:

The following problems have been found:

ERROR: /tmp/abs_41dnbwoar_/clone/recipe/meta.yaml:29: cython_needs_compiler: Cython generates C code, which will need to be compiled
Errors were found

anaconda-pkg-build · 2023-05-08T12:50:10Z

Linter check found the following problems:

The following problems have been found:

ERROR: /tmp/abs_22li9c05x_/clone/recipe/meta.yaml:30: cython_needs_compiler: Cython generates C code, which will need to be compiled
Errors were found

anaconda-pkg-build · 2023-05-08T12:55:27Z

Linter check found the following problems:

The following problems have been found:

ERROR: /tmp/abs_79upalxn97/clone/recipe/meta.yaml:30: cython_needs_compiler: Cython generates C code, which will need to be compiled
Errors were found

JeanChristopheMorinPerso · 2023-05-08T13:33:53Z

recipe/meta.yaml

-    - kernprof=kernprof:main
-  # package is required on linux-s390x
-  skip: True  [s390x]
+    - kernprof = kernprof:main

 requirements:
  build:
    - {{ compiler('cxx') }}
    - cmake


Upstream uses cmake >= 3.21.2 (https://github.com/pyutils/line_profiler/blob/v4.0.3/requirements/build.txt#L6)

See my comment about ninja

JeanChristopheMorinPerso · 2023-05-08T13:34:16Z

recipe/meta.yaml


 requirements:
  build:
    - {{ compiler('cxx') }}
    - cmake
-    - make      # [unix]
+    - ninja


Upstream uses ninja >= 1.10.2 (https://github.com/pyutils/line_profiler/blob/v4.0.3/requirements/build.txt#L7).

For the build section, conda-build always will pick up the latest version of a package. And our current version is 1.10.2 so it's not needed to pin it here

For example, you can check the final recipe in any artifacts where ninja was used (in the info/recipe folder) https://anaconda.org/anaconda/nitro/2.7.dev6/download/win-64/nitro-2.7.dev6-h6c2663c_0.tar.bz2 and a corresponding recipe from the aggregate https://github.com/AnacondaRecipes/nitro-feedstock/blob/b45e18d5242c51b4dcf661baa7b2cfd563d9671e/recipe/meta.yaml#L20

Yeah, it'll pick the latest. But it might be a good idea to stick to what upstream does. Or at least that's what I think. Anyway, not a blocker.

anaconda-pkg-build · 2023-05-08T17:26:52Z

Linter check found the following problems:

The following problems have been found:

ERROR: /tmp/abs_70xsb_n1w3/clone/recipe/meta.yaml:30: cython_needs_compiler: Cython generates C code, which will need to be compiled
Errors were found

DOR update to 4.0.3

f9d574e

Release 4.0.3

06888be

skupr-anaconda self-assigned this May 8, 2023

Fix env veriable on win, use MACOSX_DEPLOYMENT_TARGET=10.12 on osx64

8461840

skupr-anaconda changed the title ~~line_profiler 4.0.3~~ [PKG-1649] line_profiler 4.0.3 May 8, 2023

Add run_constrained, fix MACOSX_DEPLOYMENT_TARGET

813d6c1

skupr-anaconda added 2 commits May 8, 2023 15:50

Remove run_constrained

6cb79a3

Fix MACOS on osx64

8442252

skupr-anaconda marked this pull request as ready for review May 8, 2023 12:58

JeanChristopheMorinPerso reviewed May 8, 2023

View reviewed changes

cbouss approved these changes May 8, 2023

View reviewed changes

JeanChristopheMorinPerso approved these changes May 8, 2023

View reviewed changes

JeanChristopheMorinPerso merged commit a0c321b into master May 8, 2023

JeanChristopheMorinPerso deleted the 4.0.3 branch May 8, 2023 17:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PKG-1649] line_profiler 4.0.3 #2

[PKG-1649] line_profiler 4.0.3 #2

skupr-anaconda commented May 8, 2023 •

edited

Loading

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

JeanChristopheMorinPerso May 8, 2023

skupr-anaconda May 8, 2023

JeanChristopheMorinPerso May 8, 2023

skupr-anaconda May 8, 2023

skupr-anaconda May 8, 2023 •

edited

Loading

JeanChristopheMorinPerso May 8, 2023

anaconda-pkg-build commented May 8, 2023

[PKG-1649] line_profiler 4.0.3 #2

[PKG-1649] line_profiler 4.0.3 #2

Conversation

skupr-anaconda commented May 8, 2023 • edited Loading

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

anaconda-pkg-build commented May 8, 2023

JeanChristopheMorinPerso May 8, 2023

Choose a reason for hiding this comment

skupr-anaconda May 8, 2023

Choose a reason for hiding this comment

JeanChristopheMorinPerso May 8, 2023

Choose a reason for hiding this comment

skupr-anaconda May 8, 2023

Choose a reason for hiding this comment

skupr-anaconda May 8, 2023 • edited Loading

Choose a reason for hiding this comment

JeanChristopheMorinPerso May 8, 2023

Choose a reason for hiding this comment

anaconda-pkg-build commented May 8, 2023

skupr-anaconda commented May 8, 2023 •

edited

Loading

skupr-anaconda May 8, 2023 •

edited

Loading