Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to b4273, fix segfault on metal macs #12

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Update to b4273, fix segfault on metal macs #12

merged 12 commits into from
Dec 17, 2024

Conversation

jnoller
Copy link

@jnoller jnoller commented Dec 6, 2024

llama.cpp 0.0.4273
gguf 0.10.0
llama.cpp-tools 0.0.4273

Destination channel: ai-staging

Links

Explanation of changes:

  • Updates llama.cpp to b4273 (12/5/24) and adjusts/fixes the patches as needed.
  • Fixes segfault on metal enabled builds by bringing back/adjusting the metal device selection patch
    • I misunderstood the upstream refactoring and thought it could be removed.

@cbouss cbouss self-requested a review December 13, 2024 13:56
Copy link

@cbouss cbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a suggestion for the build number.

One question for a later build, do you think we could take advantage of GGML_CPU_ALL_VARIANTS in a later build?

{% set gguf_version = "0.10.0"%}
{% set build_number = 0 %}
{% set build_number = 1 %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see 4273 on ai-staging, it seems this could be reset to 0.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I incremented it to fix prefect, fixing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbouss I haven't dug into the GGML_CPU_ALL_VARIANTS stuff as of yet, I'll do that after this update.

@jnoller jnoller merged commit 97a31ea into main Dec 17, 2024
8 checks passed
@jnoller jnoller deleted the b4255 branch January 6, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants