recbole 1.2.0 ❄️ #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| 0001-update-colorlog-pinning.patch eol=crlf | ||
| 0002-update-randomstate-to-default_rng-for-hyperopt.patch eol=crlf |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,33 @@ | ||
| About recbole-feedstock | ||
| ======================= | ||
|
|
||
| Feedstock license: [BSD-3-Clause](LICENSE) | ||
|
|
||
| Home: https://recbole.io | ||
|
|
||
| Package license: MIT | ||
|
|
||
| Summary: RecBole is developed based on Python and PyTorch for reproducing and developing recommendation algorithms in a unified, comprehensive and efficient framework for research purpose. In the first version, our library includes 53 recommendation algorithms, covering four major categories: General Recommendation, Sequential Recommendation, Context-aware Recommendation and Knowledge-based Recommendation. | ||
|
|
||
|
|
||
| Current release info | ||
| ==================== | ||
|
|
||
| | Name | Downloads | Version | Platforms | | ||
| | --- | --- | --- | --- | | ||
| | [](https://anaconda.org/anaconda/recbole) | [](https://anaconda.org/anaconda/recbole) | [](https://anaconda.org/anaconda/recbole) | [](https://anaconda.org/anaconda/recbole) | | ||
|
|
||
| Installing recbole | ||
| ================== | ||
|
|
||
| Installing `recbole` from the main channel can be achieved by: | ||
|
|
||
| ``` | ||
| conda install recbole | ||
| ``` | ||
|
|
||
| It is possible to list all of the versions of `recbole` available on your platform with `conda`: | ||
|
|
||
| ``` | ||
| conda search recbole | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| upload_channels: | ||
| - sfe1ed40 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,154 @@ | ||
| {% set name = "recbole" %} | ||
| {% set version = "1.2.0" %} | ||
|
|
||
| package: | ||
| name: {{ name|lower }} | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| - url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/recbole-{{ version }}.tar.gz | ||
| sha256: 132a8a706462b26bed82d409b67fbc09e90b3a49b607c7ba76c2f1718d8ddc17 | ||
| patches: | ||
| - patches/0001-update-colorlog-pinning.patch | ||
| - patches/0002-update-randomstate-to-default_rng-for-hyperopt.patch | ||
| # use github release archive for tests | ||
| - url: https://github.com/RUCAIBox/RecBole/archive/refs/tags/v{{ version }}.tar.gz | ||
| sha256: 1bc77a567083884b41ddd652b9b35078a0c3554c39ca38ab825ab2681eef138e | ||
| folder: gh_src | ||
|
|
||
| build: | ||
| number: 0 | ||
| # s390x: kmeans-pytorch (numba) unavailable | ||
| # py>=312: ray unavailable | ||
| skip: True # [py<38 or py>311 or s390x] | ||
| script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation | ||
|
|
||
| requirements: | ||
| build: | ||
| - patch # [not win] | ||
| - m2-patch # [win] | ||
| host: | ||
| - python | ||
| - pip | ||
| - setuptools | ||
| - wheel | ||
| run: | ||
| - python | ||
| - pytorch >=1.10.0 | ||
| - numpy >=1.17.2 | ||
| # Introduced upper pinning for scipy because of | ||
| # https://github.com/RUCAIBox/RecBole/issues/2034 | ||
| # https://github.com/RUCAIBox/RecBole/issues/2090 | ||
| # similar to any other like | ||
| # https://github.com/mmaelicke/scikit-gstat/issues/178 | ||
| # it can be removed when issues are closed. | ||
| - scipy >=1.6.0,<1.13.0a0 | ||
| - pandas >=1.3.0 | ||
| - tqdm >=4.48.2 | ||
| # colorlog pinning relaxed to lower bound instead of exact | ||
| # (we have more recent version and it seems to work). | ||
| - colorlog >=4.7.2 | ||
| - colorama 0.4.4 | ||
| - scikit-learn >=0.23.2 | ||
| - pyyaml >=5.1.0 | ||
| - tensorboard >=2.5.0 | ||
| - thop >=0.1.1.post2207130030 | ||
| - tabulate >=0.8.10 | ||
| - plotly >=4.0.0 | ||
| - texttable >=0.9.0 | ||
| - psutil >=5.9.0 | ||
| # ray-tune is needed: | ||
| # https://github.com/RUCAIBox/RecBole/blob/v1.2.0/recbole/quick_start/quick_start.py#L20 | ||
| # https://github.com/RUCAIBox/RecBole/blob/v1.2.0/conda/meta.yaml#L44 | ||
| - ray-tune >=1.13.0,<=2.6.3 | ||
| run_constrained: | ||
| # originally ==0.2.5 adapted with a patch | ||
| # to work with the more recent version we | ||
| # have (0.2.7) | ||
| - hyperopt >=0.2.5 | ||
|
There was a problem hiding this comment. should it be run_constrained? It's an extras_require There was a problem hiding this comment. it is, the suggested smoke test from upstream uses it, though (see my comment in the issue here: RUCAIBox/RecBole#2105). unfortunately, I did not receive any answer also for the rest of the seemingly optional dependencies (see comment a few lines before, and also in the above issue link). Therefore, I moved all of those optional deps except some that we do not have to There was a problem hiding this comment.
ref: RUCAIBox/RecBole#2105 (comment) Therefore, I am moving the optional dependencies in |
||
|
|
||
| # skip tests KGIN and MCCLK recommenders (they use | ||
| # torch-scatter, optional and unavailable) | ||
| {% set tests_to_skip = "test_kgin" %} | ||
| {% set tests_to_skip = tests_to_skip + " or test_mcclk" %} | ||
| # skip tests KGAT recommenders (they use dgl, optional and unavailable) | ||
| {% set tests_to_skip = tests_to_skip + " or test_kgat" %} | ||
| # faiss-cpu not available for some MKL issue for py 3.8 on osx-64 | ||
| # https://github.com/AnacondaRecipes/faiss-split-feedstock/blob/main/recipe/meta.yaml#L112 | ||
| # also, this problem occurs for osx-64 on "from . import _swigfaiss" then "_mkl_blas_caxpy" | ||
| # is not found: | ||
| # https://github.com/facebookresearch/faiss/issues/1755 | ||
| # https://discourse.cmake.org/t/mkl-64lp-versus-64ilp-difficulties/1223 | ||
| {% set tests_to_skip = tests_to_skip + " or test_NCL" %} # [osx and x86_64] | ||
| {% set tests_to_skip = tests_to_skip + " or TestSequentialRecommender" %} # [osx or (linux and aarch64)] | ||
|
|
||
|
|
||
| test: | ||
| imports: | ||
| - recbole | ||
| requires: | ||
| - pip | ||
| - pytest | ||
| - hyperopt | ||
| # The following dependencies are specified in the CI | ||
| # and they are optional. | ||
| # We contacted the upstream authors and they seem optional: | ||
| # https://github.com/RUCAIBox/RecBole/issues/2105#issuecomment-2559262386 | ||
| # Most of the recommenders are available optionally | ||
| # except KGAT (missing 'dgl'), KGIN, and MCCLK (missing | ||
| # 'torch-scatter'). | ||
| # https://github.com/RUCAIBox/RecBole/blob/v1.2.0/.github/workflows/python-package.yml#L36-L51 | ||
| - kmeans-pytorch | ||
| - xgboost | ||
| - lightgbm | ||
| - faiss-cpu | ||
| - networkx | ||
| - protobuf #3.19.0 | ||
| source_files: | ||
| - gh_src/run_recbole.py | ||
| - gh_src/tests | ||
| commands: | ||
| - pip check | ||
| - cd gh_src | ||
| # Smoke test from the CI | ||
| # https://github.com/RUCAIBox/RecBole/blob/v1.2.0/.github/workflows/python-package.yml#L55 | ||
| - python run_recbole.py --model=BPR --epochs=2 | ||
| # Tests run as specified in run_test.sh | ||
| # https://github.com/RUCAIBox/RecBole/blob/v1.2.0/run_test.sh#L7C1-L7C48 | ||
| # "python -m pytest" is used instead of "pytest" | ||
| # As suggested in | ||
| # https://github.com/RUCAIBox/RecBole/blob/v1.2.0/.github/workflows/python-package.yml#L52 | ||
| - python -m pytest -vv tests/config/test_config.py | ||
| - python -m pytest -vv tests/config/test_overall.py | ||
| # config tests | ||
| - python tests/config/test_command_line.py --use_gpu=False --valid_metric=Recall@10 --metrics="['Recall']" --epochs=200 --learning_rate=0.3 | ||
| # evaluation_setting tests | ||
| - python -m pytest -vv tests/evaluation_setting | ||
| # model tests | ||
| - python -m pytest -vv tests/model/test_model_auto.py -k "not ({{ tests_to_skip }})" | ||
| # disabled: requires manual intervention | ||
| # - python -m pytest -vv tests/model/test_model_manual.py | ||
| # data tests | ||
| - python -m pytest -vv tests/data/test_dataset.py | ||
| - python -m pytest -vv tests/data/test_dataloader.py | ||
| # hyper_tuning tests | ||
| - python -m pytest -vv tests/hyper_tuning/test_hyper_tuning.py | ||
|
|
||
| about: | ||
| home: https://recbole.io | ||
| summary: A unified, comprehensive and efficient recommendation library | ||
| license: MIT | ||
| license_family: MIT | ||
| license_file: LICENSE | ||
| description: | | ||
| RecBole is developed based on Python and PyTorch for reproducing and developing | ||
| recommendation algorithms in a unified, comprehensive and efficient framework | ||
| for research purpose. In the first version, our library includes 53 recommendation | ||
| algorithms, covering four major categories: General Recommendation, Sequential | ||
| Recommendation, Context-aware Recommendation and Knowledge-based Recommendation. | ||
| doc_url: https://recbole.io/docs | ||
| dev_url: https://github.com/RUCAIBox/RecBole | ||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - lorepirri | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| From dc6746147b2d24edb5b0049698facea040c55186 Mon Sep 17 00:00:00 2001 | ||
| From: Lorenzo Pirritano <[email protected]> | ||
| Date: Fri, 1 Nov 2024 11:16:58 +0100 | ||
| Subject: [PATCH 1/2] update colorlog pinning | ||
|
|
||
| --- | ||
| setup.py | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| diff --git a/setup.py b/setup.py | ||
| index 9fa8cba..8c1334b 100644 | ||
| --- a/setup.py | ||
| +++ b/setup.py | ||
| @@ -12,7 +12,7 @@ install_requires = [ | ||
| "scipy>=1.6.0", | ||
| "pandas>=1.4.0", | ||
| "tqdm>=4.48.2", | ||
| - "colorlog==4.7.2", | ||
| + "colorlog>=4.7.2", | ||
| "colorama==0.4.4", | ||
| "scikit_learn>=0.23.2", | ||
| "pyyaml>=5.1.0", | ||
| -- | ||
| 2.39.1 | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| From 609847dbc848e8d8f9babc3534e34dc74d6d78b1 Mon Sep 17 00:00:00 2001 | ||
| From: Lorenzo Pirritano <[email protected]> | ||
| Date: Fri, 1 Nov 2024 16:06:00 +0100 | ||
| Subject: [PATCH 2/2] update RandomState to default_rng for hyperopt | ||
|
|
||
| NB this patch file must have CRLF line endings because the source file | ||
| that patches has CRLF line endings. This is achieved in .gitattributes | ||
|
|
||
| Fixes: | ||
| 'numpy.random.mtrand.RandomState' object has no attribute 'integers' | ||
|
|
||
| For using new hyperopt 0.2.7 rather than the one set by upstream 0.2.5. | ||
|
|
||
| See: https://github.com/hyperopt/hyperopt/issues/838 | ||
|
|
||
| --- | ||
| recbole/trainer/hyper_tuning.py | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| diff --git a/recbole/trainer/hyper_tuning.py b/recbole/trainer/hyper_tuning.py | ||
| index ee1cfd6..cad9a65 100644 | ||
| --- a/recbole/trainer/hyper_tuning.py | ||
| +++ b/recbole/trainer/hyper_tuning.py | ||
| @@ -113,7 +113,7 @@ def exhaustive_search(new_ids, domain, trials, seed, nbMaxSucessiveFailures=1000 | ||
| ] | ||
| ) | ||
|
|
||
| - rng = np.random.RandomState(seed) | ||
| + rng = np.random.default_rng(seed) | ||
| rval = [] | ||
| for _, new_id in enumerate(new_ids): | ||
| newSample = False | ||
| -- | ||
| 2.39.1 | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to build ray so you can get 3.12? I suppose this depends on whether snowflake wants to pay for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danpetry we are on hold for this one (see ticket). We do have ray in our pipeline, if it's out before we get the OK for this one then I will remove the skip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ray-tunedoes not have yetpy==3.12variant.skipping
py==312because this ticket was on hold waiting for feedback for too long already.