Adds GET products/all for privileged users #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marfavi
requested changes
Dec 11, 2023
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Products/ProductResponse.cs
Show resolved
Hide resolved
marfavi
requested changes
Dec 11, 2023
A-Guldborg
changed the title
marfavi
requested changes
Dec 12, 2023
Co-authored-by: Omid Marfavi <[email protected]>
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API adds the endpoint GET /api/v2/products/all, which returns all products, regardless of usergroup or visibility.
This endpoint will be used for the product management frontend in AnalogIO/shifty-webapp#20, discussed in #217 (and slack).
This endpoint is only accessible for users with Board privileges and
will allow board members to manage the visibilty of products or products
that they otherwise don't have access to themselves in the app.
Some weird merge conflicts arised on #232 after #234 was made. Probably due to me branching out from the wrong branch initially. Here is a new pull request instead :)