Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Change View of accounts into RecyclerView #710

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

MBlokhuijzen
Copy link
Contributor

No description provided.

@willlunniss
Copy link
Contributor

What testing have you done on this (Android Device/number of accounts)?

Would you consider switching straight to RecyclerView instead to give a better layout on tablets?

@alorma was looking at doing some re-working, but haven't heard from him in a while.

@MBlokhuijzen
Copy link
Contributor Author

Tested it on a Nexus 5 with 2 Accounts.
Removed the ScrollView, it seemed odd to be on top of the layout instead around the ListView

Could try to change it into a RecyclerView, I didn't test it on a tablet.

@nelenkov
Copy link
Contributor

nelenkov commented Oct 7, 2015

Could you make the diff readable? Not sure what you changed, but it looks like the whole activity class has been replaced, which is not the case. Also, CheckboxListener is not really a meaningful class name, consider renaming (e.g., AccountSelectedListener or some such).

@MBlokhuijzen
Copy link
Contributor Author

Not sure how to make it readable. Screwed up the indenting. Changed it to a RecyclerView and renamed the Listener, thanks for the tip.

Tested on the same device.

@MBlokhuijzen MBlokhuijzen changed the title Change View of accounts into ListView Change View of accounts into RecyclerView Oct 8, 2015
@willlunniss
Copy link
Contributor

Just tested on my Nexus 5 running 6.0 and the apps disappear when refreshing

As for the formatting, convert the double spaces back to tabs and it should show that you have only changed part of the class

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants