Pass in schema to GetFieldByRelation

This will be temporary, as the properties required by this function will medium-long term on the Collection field set, not the schema.
AndrewSisley · Sep 29, 2023 · 9b65924 · 9b65924
1 parent aee2055
commit 9b65924
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/client/descriptions.go b/client/descriptions.go
@@ -55,8 +55,9 @@ func (col CollectionDescription) GetFieldByRelation(
 	relationName string,
 	otherCollectionName string,
 	otherFieldName string,
+	schema *SchemaDescription,
 ) (FieldDescription, bool) {
-	for _, field := range col.Schema.Fields {
+	for _, field := range schema.Fields {
 		if field.RelationName == relationName && !(col.Name == otherCollectionName && otherFieldName == field.Name) {
 			return field, true
 		}

diff --git a/db/collection_update.go b/db/collection_update.go
@@ -365,11 +365,13 @@ func (c *collection) patchPrimaryDoc(
 		return err
 	}
 	primaryCol = primaryCol.WithTxn(txn)
+	primarySchema := primaryCol.Schema()
 
 	primaryField, ok := primaryCol.Description().GetFieldByRelation(
 		relationFieldDescription.RelationName,
 		secondaryCollectionName,
 		relationFieldDescription.Name,
+		&primarySchema,
 	)
 	if !ok {
 		return client.NewErrFieldNotExist(relationFieldDescription.RelationName)

diff --git a/planner/type_join.go b/planner/type_join.go
@@ -263,6 +263,7 @@ func (p *Planner) makeTypeJoinOne(
 		subTypeFieldDesc.RelationName,
 		parent.sourceInfo.collectionDescription.Name,
 		subTypeFieldDesc.Name,
+		&subTypeCollectionDesc.Schema,
 	)
 	if !subTypeFieldNameFound {
 		return nil, client.NewErrFieldNotExist(subTypeFieldDesc.RelationName)
@@ -489,6 +490,7 @@ func (p *Planner) makeTypeJoinMany(
 		subTypeFieldDesc.RelationName,
 		parent.sourceInfo.collectionDescription.Name,
 		subTypeFieldDesc.Name,
+		&subTypeCollectionDesc.Schema,
 	)
 
 	if !rootNameFound {