WIP - Prevent mutations from secondary side of relation

client/document.go

@@ -241,11 +241,30 @@ func validateFieldSchema(val any, field FieldDefinition) (NormalValue, error) {
 		if err != nil {
 			return nil, err
 		}
+
+		_, err = NewDocIDFromString(v)
+		if err != nil {
+			return nil, err
+		}
+
 		return NewNormalString(v), nil
 	}
 
 	switch field.Kind {
-	case FieldKind_DocID, FieldKind_NILLABLE_STRING, FieldKind_NILLABLE_BLOB:
+	case FieldKind_DocID:
+		v, err := getString(val)
+		if err != nil {
+			return nil, err
+		}
+
+		_, err = NewDocIDFromString(v)
+		if err != nil {
+			return nil, err
+		}
+
+		return NewNormalString(v), nil
+
+	case FieldKind_NILLABLE_STRING, FieldKind_NILLABLE_BLOB:
 		v, err := getString(val)
 		if err != nil {
 			return nil, err
@@ -692,6 +711,17 @@ func (doc *Document) Set(field string, value any) error {
 	if !exists {
 		return NewErrFieldNotExist(field)
 	}
+
+	if fd.Kind == FieldKind_DocID && strings.HasSuffix(field, request.RelatedObjectID) {
+		objFieldName := strings.TrimSuffix(field, request.RelatedObjectID)
+		ofd, exists := doc.collectionDefinition.GetFieldByName(objFieldName)
+		if exists && !ofd.IsPrimaryRelation {
+			return NewErrCannotSetRelationFromSecondarySide(field)
+		}
+	} else if fd.Kind.IsObject() && !fd.IsPrimaryRelation {
+		return NewErrCannotSetRelationFromSecondarySide(field)
+	}
+
 	if fd.Kind.IsObject() && !fd.Kind.IsArray() {
 		if !strings.HasSuffix(field, request.RelatedObjectID) {
 			field = field + request.RelatedObjectID

client/errors.go

@@ -34,6 +34,7 @@ const (
 	errCanNotTurnNormalValueIntoArray      string = "can not turn normal value into array"
 	errCanNotMakeNormalNilFromFieldKind    string = "can not make normal nil from field kind"
 	errFailedToParseKind                   string = "failed to parse kind"
+	errCannotSetRelationFromSecondarySide  string = "cannot set relation from secondary side"
 )
 
 // Errors returnable from this package.
@@ -190,3 +191,7 @@ func ReviveError(message string) error {
 		return fmt.Errorf("%s", message)
 	}
 }
+
+func NewErrCannotSetRelationFromSecondarySide(name string) error {
+	return errors.New(errCannotSetRelationFromSecondarySide, errors.NewKV("Name", name))
+}

internal/request/graphql/schema/generate.go

@@ -566,6 +566,14 @@ func (g *Generator) buildMutationInputTypes(collections []client.CollectionDefin
 					continue
 				}
 
+				if field.Kind == client.FieldKind_DocID && strings.HasSuffix(field.Name, request.RelatedObjectID) {
+					objFieldName := strings.TrimSuffix(field.Name, request.RelatedObjectID)
+					ofd, exists := collection.GetFieldByName(objFieldName)
+					if exists && !ofd.IsPrimaryRelation {
+						continue
+					}
+				}
+
 				var ttype gql.Type
 				if field.Kind.IsObject() {
 					if field.Kind.IsArray() {

tests/integration/mutation/create/field_kinds/one_to_many/with_alias_test.go

@@ -94,35 +94,6 @@ func TestMutationCreateOneToMany_AliasedRelationNameNonExistingRelationManySide_
 	}
 	executeTestCase(t, test)
 }
-func TestMutationCreateOneToMany_AliasedRelationNameInvalidIDManySide_CreatedDoc(t *testing.T) {
-	test := testUtils.TestCase{
-		Description: "One to many create mutation, invalid id, from the many side, with alias",
-		Actions: []any{
-			testUtils.CreateDoc{
-				CollectionID: 0,
-				Doc: `{
-					"name": "Painted House",
-					"author": "ValueDoesntMatter"
-				}`,
-			},
-			testUtils.Request{
-				Request: `query {
-					Book {
-						name
-					}
-				}`,
-				Results: map[string]any{
-					"Book": []map[string]any{
-						{
-							"name": "Painted House",
-						},
-					},
-				},
-			},
-		},
-	}
-	executeTestCase(t, test)
-}
 
 func TestMutationCreateOneToMany_AliasedRelationNameToLinkFromManySide(t *testing.T) {
 	test := testUtils.TestCase{

tests/integration/mutation/create/field_kinds/one_to_one/with_alias_test.go

@@ -73,23 +73,6 @@ func TestMutationCreateOneToOne_UseAliasWithNonExistingRelationPrimarySide_Creat
 	executeTestCase(t, test)
 }
 
-func TestMutationCreateOneToOne_UseAliasWithNonExistingRelationSecondarySide_Error(t *testing.T) {
-	test := testUtils.TestCase{
-		Description: "One to one create mutation, alias relation, from the secondary side",
-		Actions: []any{
-			testUtils.CreateDoc{
-				CollectionID: 0,
-				Doc: `{
-					"name": "Painted House",
-					"author": "bae-be6d8024-4953-5a92-84b4-f042d25230c6"
-				}`,
-				ExpectedError: "document not found or not authorized to access",
-			},
-		},
-	}
-	executeTestCase(t, test)
-}
-
 func TestMutationCreateOneToOne_UseAliasedRelationNameToLink_QueryFromPrimarySide(t *testing.T) {
 	test := testUtils.TestCase{
 		Description: "One to one create mutation with an alias relation.",
@@ -153,7 +136,7 @@ func TestMutationCreateOneToOne_UseAliasedRelationNameToLink_QueryFromPrimarySid
 	executeTestCase(t, test)
 }
 
-func TestMutationCreateOneToOne_UseAliasedRelationNameToLink_QueryFromSecondarySide(t *testing.T) {
+func TestMutationCreateOneToOne_UseAliasedRelationNameToLink_Errors(t *testing.T) {
 	test := testUtils.TestCase{
 		Description: "One to one create mutation from secondary side with alias relation.",
 		Actions: []any{
@@ -169,46 +152,7 @@ func TestMutationCreateOneToOne_UseAliasedRelationNameToLink_QueryFromSecondaryS
 					"name":   "Painted House",
 					"author": testUtils.NewDocIndex(1, 0),
 				},
-			},
-			testUtils.Request{
-				Request: `query {
-					Author {
-						name
-						published {
-							name
-						}
-					}
-				}`,
-				Results: map[string]any{
-					"Author": []map[string]any{
-						{
-							"name": "John Grisham",
-							"published": map[string]any{
-								"name": "Painted House",
-							},
-						},
-					},
-				},
-			},
-			testUtils.Request{
-				Request: `query {
-					Book {
-						name
-						author {
-							name
-						}
-					}
-				}`,
-				Results: map[string]any{
-					"Book": []map[string]any{
-						{
-							"name": "Painted House",
-							"author": map[string]any{
-								"name": "John Grisham",
-							},
-						},
-					},
-				},
+				ExpectedError: "cannot set relation from secondary side",
 			},
 		},
 	}

tests/integration/mutation/create/field_kinds/one_to_one/with_null_value_test.go

@@ -32,91 +32,24 @@ func TestMutationCreateOneToOne_WithExplicitNullOnPrimarySide(t *testing.T) {
 					}
 				`,
 			},
-			testUtils.CreateDoc{
-				Doc: `{
-					"name": "How to Be a Canadian",
-					"author": null
-				}`,
-			},
-			testUtils.CreateDoc{
-				Doc: `{
-					"name": "Secrets at Maple Syrup Farm",
-					"author": null
-				}`,
-			},
 			testUtils.CreateDoc{
 				CollectionID: 1,
 				DocMap: map[string]any{
-					"name":      "Will Ferguson",
-					"published": testUtils.NewDocIndex(0, 0),
+					"name": "Will Ferguson",
 				},
 			},
-			testUtils.Request{
-				Request: `
-					query {
-						Book {
-							name
-							author {
-								name
-							}
-						}
-					}`,
-				Results: map[string]any{
-					"Book": []map[string]any{
-						{
-							"name":   "Secrets at Maple Syrup Farm",
-							"author": nil,
-						},
-						{
-							"name": "How to Be a Canadian",
-							"author": map[string]any{
-								"name": "Will Ferguson",
-							},
-						},
-					},
-				},
-			},
-		},
-	}
-
-	testUtils.ExecuteTestCase(t, test)
-}
-
-func TestMutationCreateOneToOne_WithExplicitNullOnSecondarySide(t *testing.T) {
-	test := testUtils.TestCase{
-		Actions: []any{
-			testUtils.SchemaUpdate{
-				Schema: `
-					type Book {
-						name: String
-						author: Author
-					}
-
-					type Author {
-						name: String
-						published: Book @primary
-					}
-				`,
-			},
 			testUtils.CreateDoc{
-				Doc: `{
-					"name": "How to Be a Canadian",
-					"author": null
-				}`,
+				DocMap: map[string]any{
+					"name":   "How to Be a Canadian",
+					"author": testUtils.NewDocIndex(1, 0),
+				},
 			},
 			testUtils.CreateDoc{
 				Doc: `{
 					"name": "Secrets at Maple Syrup Farm",
 					"author": null
 				}`,
 			},
-			testUtils.CreateDoc{
-				CollectionID: 1,
-				DocMap: map[string]any{
-					"name":      "Will Ferguson",
-					"published": testUtils.NewDocIndex(0, 0),
-				},
-			},
 			testUtils.Request{
 				Request: `
 					query {