feat: revert if zero amount for GenericHarvester

AngleProtocol · Oct 25, 2024 · e7fd84f · e7fd84f
1 parent 08d8a28
commit e7fd84f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 16 deletions.
diff --git a/contracts/helpers/GenericHarvester.sol b/contracts/helpers/GenericHarvester.sol
@@ -108,22 +108,19 @@ contract GenericHarvester is BaseHarvester, IERC3156FlashBorrower, RouterSwapper
         YieldBearingParams memory yieldBearingInfo = yieldBearingData[yieldBearingAsset];
         (uint8 increase, uint256 amount) = _computeRebalanceAmount(yieldBearingAsset, yieldBearingInfo);
         amount = (amount * scale) / 1e9;
+        if (amount == 0) revert ZeroAmount();
 
         (SwapType swapType, bytes memory data) = abi.decode(extraData, (SwapType, bytes));
-
-        if (amount > 0) {
-            try transmuter.updateOracle(yieldBearingInfo.asset) {} catch {}
-
-            adjustYieldExposure(
-                amount,
-                increase,
-                yieldBearingAsset,
-                yieldBearingInfo.asset,
-                (amount * (1e9 - maxSlippage)) / 1e9,
-                swapType,
-                data
-            );
-        }
+        try transmuter.updateOracle(yieldBearingInfo.asset) {} catch {}
+        adjustYieldExposure(
+            amount,
+            increase,
+            yieldBearingAsset,
+            yieldBearingInfo.asset,
+            (amount * (1e9 - maxSlippage)) / 1e9,
+            swapType,
+            data
+        );
     }
 
     /// @notice Burns `amountStablecoins` for one yieldBearing asset, swap for asset then mints deposit tokens

diff --git a/test/fuzz/GenericHarvester.t.sol b/test/fuzz/GenericHarvester.t.sol
@@ -144,9 +144,14 @@ contract GenericHarvestertTest is Test, FunctionUtils, CommonUtils {
         assertEq(agToken.balanceOf(alice), amount);
     }
 
-    function test_IncreaseExposure_STEAK_USDC() public {}
+    function test_Harvest_ZeroAmount() public {
+        vm.expectRevert(Errors.ZeroAmount.selector);
+        harvester.harvest(STEAK_USDC, 1e9, abi.encode(uint8(SwapType.VAULT), new bytes(0)));
+    }
+
+    function test_Harvest_IncreaseExposureSTEAK_USDC() public {}
 
-    function test_DecreaseExposure_STEAK_USDC() public {}
+    function test_Harvest_DecreaseExposureSTEAK_USDC() public {}
 
     function _loadReserve(address token, uint256 amount) internal {
         if (token == USDM) {