Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy-oracle-PT-Dec-maturity #257

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

GuillaumeNervoXS
Copy link
Contributor

No description provided.

string public constant description = "PT-weETH/weETH Oracle";

constructor(
IAccessControlManager accessControlManager,

Check notice

Code scanning / Slither

Local variable shadowing Low

string public constant description = "PT-ezETH/weETH Oracle";

constructor(
IAccessControlManager accessControlManager,

Check notice

Code scanning / Slither

Local variable shadowing Low

@0xtekgrinder 0xtekgrinder self-requested a review June 14, 2024 12:28
Copy link
Contributor

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove broadcast folder otherwise looks good

test/foundry/oracles/pendle/MorphoFeedPTezETHDec24.t.sol Outdated Show resolved Hide resolved
@0xtekgrinder 0xtekgrinder self-requested a review June 17, 2024 16:25
Comment on lines +18 to +25
function _pendlePTPrice(IPMarket _market, uint32 _twapDuration) internal view virtual returns (uint256, uint256) {
(uint256 syIndex, uint256 pyIndex) = PendlePYOracleLib.getSYandPYIndexCurrent(_market);
if (syIndex >= pyIndex) {
return (PendlePYOracleLib.getPtToAssetRateRaw(_market, _twapDuration).divDown(syIndex), syIndex);
} else {
return (PendlePYOracleLib.getPtToAssetRateRaw(_market, _twapDuration).divDown(pyIndex), syIndex);
}
}

Check warning

Code scanning / Slither

Dead-code Warning

FeedPTForSY._pendlePTPrice(IPMarket,uint32) is never used and should be removed
Copy link
Contributor

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a file to remove otherwise looks good to me

contracts/oracle/FeedPTForSY.sol Show resolved Hide resolved
@0xtekgrinder 0xtekgrinder self-requested a review June 18, 2024 07:49
@GuillaumeNervoXS GuillaumeNervoXS merged commit 1b128e2 into main Jun 18, 2024
6 checks passed
@GuillaumeNervoXS GuillaumeNervoXS deleted the feat--deploy-oracle-PT-Dec-maturity branch June 18, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants