Default fees #53
Merged
Default fees #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function setCampaignFees(uint32 campaignType, uint256 _fees) external onlyGovernor { | ||
| /// @notice Sets the fees specific for a campaign | ||
| /// @dev To waive the fees for a campaign, set its fees to 1 | ||
| function setCampaignFees(uint32 campaignType, uint256 _fees) external onlyGovernorOrGuardian { |
There was a problem hiding this comment.
What are the rational for guaridan or governor access control?
Picodes
approved these changes
Feb 2, 2024
sogipec
added a commit
that referenced
this pull request
Feb 5, 2024
* fix updates * feat: campaign specific fees * change old distrib * feat: change access control
sogipec
added a commit
that referenced
this pull request
Feb 16, 2024
* feat: merklV2 poc * merkl V2 contracts * feat: distribution creator concatenated * feat: delete distribution creator * feat: rework for wrapping new Merkl version in the contract * feat guardian governor * feat: distribution update * feat: add pagination in reward tokens * mock deployment merkl * feat: update creator * feat: change creator * base deployment * feat: wrapping campaigns * fix: DistributionCreator v2 * Iterations (#50) * fix: comments * fix updates * feat merkl V2 iterations * feat: checks on top * feat: last tests * feat: getDistribution getter (#51) * feat: chainId in campaignId (#52) * Default fees (#53) * fix updates * feat: campaign specific fees * change old distrib * feat: change access control * fix: signing * fix: signing (#54) * fix updates * feat: deployment * feat: deploy-v2 * feat: deployments everywhere * tests: update all tests for v2 * chore: revert hardhat config back to pre v2 * tests: add signAndCreateCampaign tests * tests: add all missings unit tests for DistributionCreator * chore: coverage ci and README * tests: correct amount computation in distributioncreation test * Scripts (#56) * feat: scripts for new owner * feat: script to test reward token * tests: revert to previous foundry tests * fix: default value for private key in hardhat c onfig --------- Co-authored-by: picodes <[email protected]> Co-authored-by: Picodes <[email protected]> Co-authored-by: 0xtekgrinder <[email protected]>
0xtekgrinder
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: merklV2 poc * merkl V2 contracts * feat: distribution creator concatenated * feat: delete distribution creator * feat: rework for wrapping new Merkl version in the contract * feat guardian governor * feat: distribution update * feat: add pagination in reward tokens * mock deployment merkl * feat: update creator * feat: change creator * base deployment * feat: wrapping campaigns * fix: DistributionCreator v2 * Iterations (#50) * fix: comments * fix updates * feat merkl V2 iterations * feat: checks on top * feat: last tests * feat: getDistribution getter (#51) * feat: chainId in campaignId (#52) * Default fees (#53) * fix updates * feat: campaign specific fees * change old distrib * feat: change access control * fix: signing * fix: signing (#54) * fix updates * feat: deployment * feat: deploy-v2 * feat: deployments everywhere * tests: update all tests for v2 * chore: revert hardhat config back to pre v2 * tests: add signAndCreateCampaign tests * tests: add all missings unit tests for DistributionCreator * chore: coverage ci and README * tests: correct amount computation in distributioncreation test * Scripts (#56) * feat: scripts for new owner * feat: script to test reward token * tests: revert to previous foundry tests * fix: default value for private key in hardhat c onfig * tests: Distributor foundry tests * tests: fork tests for distributions * tests: distributor claim tests * fix: forgot import in DistributioNCreators tests * chore: add chain uris to ci --------- Co-authored-by: Pablo Veyrat <[email protected]> Co-authored-by: picodes <[email protected]> Co-authored-by: Pablo Veyrat <[email protected]> Co-authored-by: Picodes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.