feat: wip merkl report type #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [holder: string]: { | ||
| [poolAddress: string]: { | ||
| details: { | ||
| [rewardId: string]: { |
There was a problem hiding this comment.
I liked the sub types too, because sometimes you only work with the sub object and you don't want to retype it
There was a problem hiding this comment.
I thought that for a start, it helps to have an overview of the type
once in prod, I agree that segmenting into smaller types is better
| }; | ||
| }; | ||
|
|
||
| export type MerklReportType = Partial<{ |
There was a problem hiding this comment.
what's this one corresponding too? I don't see the same params as in merkl-dispute
There was a problem hiding this comment.
it was inspired from MerklReport
|
|
||
| import { AggregatedRewardsType, MerklSupportedChainIdsType } from '.'; | ||
|
|
||
| export type OnChainParamsType = { |
There was a problem hiding this comment.
Is it a convention to add Type at the end of the name?
There was a problem hiding this comment.
yes it's a convention for clarity and readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.