Skip to content

Commit

Permalink
Update Project info
Browse files Browse the repository at this point in the history
Update Display name
Update Application category type
Update UI to display both the project version number and the build number
Update the version number and build number
  • Loading branch information
kishorepran committed Apr 9, 2024
1 parent fcf0e41 commit f24d9f2
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
16 changes: 8 additions & 8 deletions animeal.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3080,14 +3080,14 @@
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
CODE_SIGN_IDENTITY = "Apple Development: Pran Kishore (CM95PV92ZY)";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 17;
CURRENT_PROJECT_VERSION = 20240409;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 2JSLPH439W;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 2JSLPH439W;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = animeal/res/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "";
INFOPLIST_KEY_LSApplicationCategoryType = "";
INFOPLIST_KEY_CFBundleDisplayName = Animeal;
INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.lifestyle";
INFOPLIST_KEY_NSCameraUsageDescription = "This app will use camera.";
INFOPLIST_KEY_NSLocationAlwaysAndWhenInUseUsageDescription = "Your precise location is used to calculate turn-by-turn directions, show your location on the map, and help improve the map.";
INFOPLIST_KEY_NSLocationWhenInUseUsageDescription = "Your precise location is used to calculate turn-by-turn directions, show your location on the map, and help improve the map.";
Expand All @@ -3103,7 +3103,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.0.33;
MARKETING_VERSION = 1.0.0;
OTHER_LDFLAGS = "-ObjC";
PRODUCT_BUNDLE_IDENTIFIER = com.epmedu.animealMobile;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -3123,13 +3123,13 @@
CODE_SIGN_IDENTITY = "Apple Distribution: Animals Project, NCLE (2JSLPH439W)";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Distribution: Animals Project, NCLE (2JSLPH439W)";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 17;
CURRENT_PROJECT_VERSION = 20240409;
DEVELOPMENT_TEAM = 2JSLPH439W;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 2JSLPH439W;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = animeal/res/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "";
INFOPLIST_KEY_LSApplicationCategoryType = "";
INFOPLIST_KEY_CFBundleDisplayName = Animeal;
INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.lifestyle";
INFOPLIST_KEY_NSCameraUsageDescription = "This app will use camera.";
INFOPLIST_KEY_NSLocationAlwaysAndWhenInUseUsageDescription = "Your precise location is used to calculate turn-by-turn directions, show your location on the map, and help improve the map.";
INFOPLIST_KEY_NSLocationWhenInUseUsageDescription = "Your precise location is used to calculate turn-by-turn directions, show your location on the map, and help improve the map.";
Expand All @@ -3145,7 +3145,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.0.33;
MARKETING_VERSION = 1.0.0;
OTHER_LDFLAGS = "-ObjC";
PRODUCT_BUNDLE_IDENTIFIER = com.epmedu.animealMobile;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
4 changes: 4 additions & 0 deletions animeal/src/App/AppInfo.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ enum AppInfo {
return Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ?? .empty
}

static var appBuildNumber: String {
return Bundle.main.infoDictionary?["CFBundleVersion"] as? String ?? .empty
}

static var appStoreShareUrl: String {
return "https://itunes.apple.com/us/app/iapps/id\(appId)?mt=8"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ extension AboutModel {
return AboutModel(
contentText: "\(L10n.More.aboutContent)",
links: AboutLink.allCases,
appVersion: "\(L10n.About.appVersion) \(AppInfo.appVersion)"
appVersion: "\(L10n.About.appVersion) \(AppInfo.appVersion) (\(AppInfo.appBuildNumber))"
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ final class AboutViewModel: AboutViewModelLifeCycle, AboutViewInteraction, About
func load() {
model.links = AboutLink.allCases
model.contentText = AboutModel.previewModel.contentText
model.appVersion = "\(L10n.About.appVersion) \(AppInfo.appVersion)"
model.appVersion = "\(L10n.About.appVersion) \(AppInfo.appVersion) (\(AppInfo.appBuildNumber))"
}

var observableModel: AboutModelProtocol {
Expand Down

0 comments on commit f24d9f2

Please sign in to comment.