-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(watcher): scanning a managed workspace only logs a warning msg #1668
base: dev
Are you sure you want to change the base?
feat(watcher): scanning a managed workspace only logs a warning msg #1668
Conversation
Features
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As seen with @MartinBelthle I'll work on the front side for this issue
cb81235
to
f533fdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that if the scan operation fails, it should be reported to the user in a clear manner, ensuring they are aware of the error. Therefore, I would prefer the task status to be set to 'failed' (accompanied by an error message) in case of failure instead of handling errors silently. If this cannot be achieved, it should be well-documented in the source code with a comment (in a verbose manner).
I'm not entirely convinced that the CannotScanInternalWorkspace
class should be an HTTPException; to me, it seems more like a standard exception that should inherit from Exception
. In this case, it would be best to declare the exception where it is used.
Regarding integration tests, some refactoring is needed. I've recently created a handy guide for this purpose. It aims to enhance fixture management and add a 'normal case' test.
b6b0367
to
5f0e15a
Compare
No description provided.