ci(github): update workflows #2121
Open
+103
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skamril
force-pushed
the
feature/update_main_workflow
branch
from
5d4258d to
c61897f
Compare
skamril
force-pushed
the
feature/update_main_workflow
branch
17 times, most recently
from
72547ba to
afdc65f
Compare
skamril
force-pushed
the
feature/update_main_workflow
branch
5 times, most recently
from
ac2fafa to
6406748
Compare
skamril
force-pushed
the
feature/update_main_workflow
branch
10 times, most recently
from
8c748a3 to
a185db5
Compare
sylvlecl
reviewed
Aug 19, 2024
| id: detect-changes | ||
| run: | | ||
| git fetch origin ${{ github.event.pull_request.base.ref }} --depth=1 | ||
| if git diff --name-only origin/${{ github.event.pull_request.base.ref }}...HEAD | grep -Eq '^antarest/|^tests/|^resources/|^requirements.*\.txt$'; then |
There was a problem hiding this comment.
The build will be affected by other configuration files (setup files, pyproject.toml, maybe alembic configuration too...): to be checked
sylvlecl
reviewed
Sep 4, 2024
| # So we use conditions to control job execution (`if: ...`) instead of `pull_request` event parameters. | ||
| # A job that is skipped will report its status as "Success". | ||
| # It will not prevent a pull request from merging, even if it is a required check. | ||
| on: [pull_request] |
There was a problem hiding this comment.
Running this workflow on pull requests will not be enough:
we still want all tests and sonarcloud to be run on main and dev branches when we merge into them.
There was a problem hiding this comment.
A pull request must be open to merge into dev and master (branch protection rules), so on: [pull_request] is enough here.
skamril
force-pushed
the
feature/update_main_workflow
branch
from
a185db5 to
892c95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.