feat(api,ui-studies): update study move #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skamril
changed the title
skamril
changed the title
skamril
force-pushed
the
bugfix/ANT-2390_move-study
branch
3 times, most recently
from
c920964 to
8b9cbca
Compare
MartinBelthle
force-pushed
the
bugfix/ANT-2390_move-study
branch
from
8b9cbca to
23ffc1c
Compare
skamril
force-pushed
the
bugfix/ANT-2390_move-study
branch
4 times, most recently
from
df59674 to
a6563cf
Compare
skamril
force-pushed
the
bugfix/ANT-2390_move-study
branch
from
4a542af to
1afbc6b
Compare
skamril
force-pushed
the
bugfix/ANT-2390_move-study
branch
2 times, most recently
from
780f89a to
c7cb378
Compare
sylvlecl
reviewed
Dec 16, 2024
| study = self.get_study(study_id) | ||
| assert_permission(params.user, study, StudyPermissionType.WRITE) | ||
| if not is_managed(study): | ||
| raise NotAManagedStudyException(study_id) | ||
| if folder_dest: | ||
| new_folder = folder_dest.rstrip("/") + f"/{study.id}" |
There was a problem hiding this comment.
Just a note for later: would probably be best to use PurePosixPath objects than just strings to represent our paths.
sylvlecl
previously approved these changes
Dec 16, 2024
hdinia
requested changes
Dec 16, 2024
skamril
force-pushed
the
bugfix/ANT-2390_move-study
branch
from
c7cb378 to
6d454f4
Compare
hdinia
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANT-2390