Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aggregation-apis): rename aggregation cols #2250

Merged
merged 5 commits into from
Dec 13, 2024
Merged

feat(aggregation-apis): rename aggregation cols #2250

merged 5 commits into from
Dec 13, 2024

Conversation

mabw-rte
Copy link
Contributor

Context:
In ANT-2428, aggregation APIs users want to have some columns in the output DataFrame to be renamed by the backend instead of having to proceed with a post-processing.

@mabw-rte mabw-rte self-assigned this Nov 26, 2024
MartinBelthle
MartinBelthle requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue I believe. Otherwise your code is pretty clean despite the nature of the subject and it's a miracle, well done
Also it would be nice to add a test on P-withdrawal - MW or P-injection - MW to ensure this works.
And another test for levels

antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
@mabw-rte mabw-rte force-pushed the feature/2428-rename-aggregation-cols branch 3 times, most recently from c6cfdb1 to f9af638 Compare December 3, 2024 11:32
@MartinBelthle MartinBelthle force-pushed the feature/2428-rename-aggregation-cols branch from f9af638 to 14bf9a6 Compare December 13, 2024 13:18
@MartinBelthle MartinBelthle force-pushed the feature/2428-rename-aggregation-cols branch from e393e25 to 3596390 Compare December 13, 2024 15:37
@MartinBelthle MartinBelthle merged commit d51e88c into dev Dec 13, 2024
9 of 11 checks passed
@MartinBelthle MartinBelthle deleted the feature/2428-rename-aggregation-cols branch December 13, 2024 16:10
@makdeuneuv makdeuneuv added this to the v3.0.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBelthle MartinBelthle MartinBelthle requested changes

@TheoPascoli TheoPascoli Awaiting requested review from TheoPascoli

@sylvlecl sylvlecl Awaiting requested review from sylvlecl

Assignees

@mabw-rte mabw-rte

Labels
api REST API back-end size/XXL
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mabw-rte @MartinBelthle @makdeuneuv