Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mypy): enforce explicit overrides #2270

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat(mypy): enforce explicit overrides #2270

wants to merge 3 commits into from
+732 −2

Conversation

sylvlecl
Copy link
Member

Using @override systematically will have benefits:

  • less errors when refactoring
  • more information when reading code

@sylvlecl sylvlecl marked this pull request as draft December 17, 2024 10:43
@sylvlecl sylvlecl changed the title feat(mypy): enable explicit overrides feat(mypy): enforce explicit overrides Dec 17, 2024
@sylvlecl sylvlecl marked this pull request as ready for review December 18, 2024 08:38
@sylvlecl sylvlecl requested review from smailio and maugde December 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smailio smailio Awaiting requested review from smailio

@maugde maugde Awaiting requested review from maugde

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvlecl @MartinBelthle