De-templatize HydroManagement::prepareNetDemand (#1679)

* De-templatize `HydroManagement::prepareNetDemand` Templates make for larger binaries since 2 functions are required. * Swap 2 lines of code
AntaresSimulatorTeam · Oct 5, 2023 · 1b89fbf · 1b89fbf
1 parent cf4a792
commit 1b89fbf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/src/solver/hydro/management/management.cpp b/src/solver/hydro/management/management.cpp
@@ -369,8 +369,7 @@ bool HydroManagement::checkMinGeneration(uint numSpace, uint year) const
     return ret;
 }
 
-template<enum Data::StudyMode ModeT>
-void HydroManagement::prepareNetDemand(uint numSpace, uint year)
+void HydroManagement::prepareNetDemand(uint numSpace, uint year, Data::StudyMode mode)
 {
     areas_.each([&](Data::Area& area) {
         uint z = area.index;
@@ -398,7 +397,7 @@ void HydroManagement::prepareNetDemand(uint numSpace, uint year)
                 netdemand = + loadSeries[hour]
                             - windSeries[hour] - scratchpad.miscGenSum[hour]
                             - solarSeries[hour] - ror[hour]
-                            - ((ModeT != Data::stdmAdequacy) ? scratchpad.mustrunSum[hour]
+                            - ((mode != Data::stdmAdequacy) ? scratchpad.mustrunSum[hour]
                                                              : scratchpad.originalMustrunSum[hour]);
             }
 
@@ -407,7 +406,7 @@ void HydroManagement::prepareNetDemand(uint numSpace, uint year)
             {
                 netdemand = loadSeries[hour]
                             - scratchpad.miscGenSum[hour] - ror[hour]
-                            - ((ModeT != Data::stdmAdequacy) ? scratchpad.mustrunSum[hour]
+                            - ((mode != Data::stdmAdequacy) ? scratchpad.mustrunSum[hour]
                                                              : scratchpad.originalMustrunSum[hour]);
 
                 area.renewable.list.each([&](const Antares::Data::RenewableCluster& cluster) {
@@ -525,11 +524,7 @@ void HydroManagement::makeVentilation(double* randomReservoirLevel,
         throw FatalError("hydro management: invalid minimum generation");
     }
 
-    if (parameters_.adequacy())
-        prepareNetDemand<Data::stdmAdequacy>(numSpace, y);
-    else
-        prepareNetDemand<Data::stdmEconomy>(numSpace, y);
-
+    prepareNetDemand(numSpace, y, parameters_.mode);
     prepareEffectiveDemand(numSpace);
 
     prepareMonthlyOptimalGenerations(randomReservoirLevel, y, numSpace);

diff --git a/src/solver/hydro/management/management.h b/src/solver/hydro/management/management.h
@@ -135,8 +135,7 @@ class HydroManagement final
     //! check minimum generation is lower than available inflows
     bool checkMinGeneration(uint numSpace, uint year) const;
     //! Prepare the net demand for each area
-    template<enum Data::StudyMode ModeT>
-    void prepareNetDemand(uint numSpace, uint year);
+    void prepareNetDemand(uint numSpace, uint year, Data::StudyMode mode);
     //! Prepare the effective demand for each area
     void prepareEffectiveDemand(uint numSpace);
     //! Monthly Optimal generations