Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Replace integers by proper enums in methods signatures #1214

Closed
wants to merge 1 commit into from
Closed

[WIP] Replace integers by proper enums in methods signatures #1214

wants to merge 1 commit into from

Conversation

sylvlecl
Copy link
Member

@sylvlecl sylvlecl commented Mar 13, 2023 •
edited
Loading

Prerequisite to #1211 :

  • using enum parameters instead of integers where relevant

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
44.3% 44.3% Duplication

@flomnes
Copy link
Member

flomnes commented Oct 5, 2023

This seems to be more than search & replace since for example timeSeriesThermal | timeSeriesLoad is not an enum.

@flomnes flomnes closed this Oct 5, 2023
@JasonMarechal25 JasonMarechal25 deleted the fix/replace-ints-with-enums branch November 6, 2023 10:28
@JasonMarechal25 JasonMarechal25 restored the fix/replace-ints-with-enums branch November 6, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvlecl @flomnes