Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deps to core #1586

Merged
merged 11 commits into from
Sep 12, 2023
2 changes: 1 addition & 1 deletion .github/workflows/windows-vcpkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
- name: Build
shell: bash
run: |
cmake --build _build --config release
cmake --build _build --config release -j2

- name: Run unfeasibility-related tests
run: |
Expand Down
10 changes: 0 additions & 10 deletions src/libs/antares/checks/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@ add_library(checks
add_library(Antares::checks ALIAS checks)

target_include_directories(checks
PRIVATE
# ${CMAKE_SOURCE_DIR}/libs/
# ${CMAKE_SOURCE_DIR}/libs/antares/study
# ${CMAKE_SOURCE_DIR}/libs/antares/inifile #adq-patch-params
# ${CMAKE_SOURCE_DIR}/libs/antares/array #area
# ${CMAKE_SOURCE_DIR}/libs/antares/io #area -> matrix -> io
# ${CMAKE_SOURCE_DIR}/libs/antares/date #area -> parameter -> date
# ${CMAKE_SOURCE_DIR}/libs/antares/writer #area -> antares/parts/thermal/cluster -> writer
# ${CMAKE_SOURCE_DIR}/libs/antares/jit #area -> matrix -> jit
# ${CMAKE_SOURCE_DIR}/libs/antares/memory/include #area -> matrix -> memory
PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}
)
Expand Down
6 changes: 3 additions & 3 deletions src/libs/antares/date/antares/date/date.h
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ class Calendar
} mapping;

//! The calendar settings
struct settings
struct Settings
{
//! Day of the week for the 1rst January
DayOfTheWeek weekday1rstJanuary;
Expand Down Expand Up @@ -355,7 +355,7 @@ class Calendar
** Reset the calendar from an instance of the class \p Parameters,
** \param parameters Simulation settings
*/
void reset(settings settings);
void reset(Settings settings);

/*!
** \brief Export the whole calendar into a CSV file
Expand All @@ -365,7 +365,7 @@ class Calendar
bool saveToCSVFile(const AnyString& filename) const;

private:
settings settings_;
Settings settings_;

}; // class Calendar
} // namespace Date
Expand Down
2 changes: 1 addition & 1 deletion src/libs/antares/date/date.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ Calendar::Calendar()
settings_.weekday1rstJanuary = monday;
}

void Calendar::reset(settings settings)
void Calendar::reset(Settings settings)
{
settings_ = settings;
reset();
Expand Down
7 changes: 5 additions & 2 deletions src/libs/antares/study/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ add_library(Antares::study ALIAS study)

target_link_libraries(study
PUBLIC
Boost::boost
yuni-static-core
Boost::boost
Antares::array #xcast
Expand All @@ -439,9 +440,11 @@ target_link_libraries(study
Antares::object
PRIVATE
Antares::exception
Antares::benchmarking
)

target_include_directories(study
PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/../..
PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/../.. #Dirty trick to allow inclusion via <antares/study/X>
# Make more than just study visible but it's the lesser evil for now
)
1 change: 0 additions & 1 deletion src/libs/antares/writer/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ target_link_libraries(result_writer
PUBLIC
Antares::benchmarking
PRIVATE
Antares::benchmarking
yuni-static-core
MINIZIP::minizip
logs
Expand Down
5 changes: 4 additions & 1 deletion src/libs/antares/writer/antares/writer/writer_factory.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@

#include "i_writer.h"
#include "result_format.h"
#include <antares/benchmarking/DurationCollector.h>

namespace Benchmarking {
class IDurationCollector;
}

namespace Antares::Solver
{
Expand Down
4 changes: 3 additions & 1 deletion src/solver/optimisation/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,6 @@ target_link_libraries(libmodel_antares
utils
sirius_solver
infeasible_problem_analysis
libantares-solver-simulation)
libantares-solver-simulation
Antares::benchmarking
)