Refactor constraint building #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-zakir
requested review from
flomnes,
JasonMarechal25,
guilpier-code and
payetvin
Co-authored-by: Florian Omnès <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
a-zakir
added a commit
that referenced
this pull request
Oct 2, 2023
* start
* add FictitiousLoad
* shortTermStorageLevel
* flowDissociation
* bindingConstraintHour
* ghost
* this is not only about constraint builder
* pay attention to the time step
* specific issue
* bug free
* smooth green?
* M&M
* Max Pumping ok?
* Area Hydro Level (_-_)
* finally
* basic
* tiny
* clean code
* add {PMin,PMax}DispatchableGeneration
* clean code
* ConsistenceNODU ok
* NbUnitsOutageLessThanNbUnitsStop
* NbDispUnitsMinBoundSinceMinUpTime
* MinDownTime
* setup Access Control
* remove comments
* remove comments
* treat major code smells
* treat major code smells 2
* more on major code smells
* update after review
* about objects lifetime
* (does not compile) cut into small pieces
* Revert "(does not compile) cut into small pieces"
This reverts commit 5a047c0.
* aesthetic
* remove comment
* smart move
* **** move
* shallow
* customize error exception
* test new variable construction design
* refactor
* update build for NODU
* clean deprecated code
* update build for NumberStoppingDispatchableUnits
* on NumberStartingDispatchableUnits
* on NumberBreakingDownDispatchableUnits
* new build NTCDirect
* missing file NTCDirect
* Interco Direct/Indirect Cost
* ShortTermStorageInjection
* ShortTermStorageWithdrawal
* ShortTermStorageLevel
* HydProd
* HydProdDown
* HydProdUp
* Pumping
* HydroLevel
* Overflow
* FinalStorage
* fix
* LayerStorage
* Psitive/Negative UnsuppliedEnergy
* remove old code
* remove code
* fix
* move
* clarity matters thanks to @sylvlecl
* There is no need for repetition
* it makes sense: Constraint->ConstraintFactory
* update
* remove redundant check
* rename things
* unused
* debug
* fiiiiiiiix
* add explicit keyword
* inspect unique_ptr
* resolve conflicts
* quick fix
* suggestion by @flomnes
Co-authored-by: Florian Omnès <[email protected]>
* add docs
* docs for new constraint classes
* update
* complete new classes documentation
* update
* update
* small changes
* small changes 2
* remove comment
* default value for constraint op
* clean code
* smell code
* smell code
* fix
* pretty
* typo
---------
Co-authored-by: Florian Omnès <[email protected]>
a-zakir
added a commit
that referenced
this pull request
Oct 2, 2023
* start
* add FictitiousLoad
* shortTermStorageLevel
* flowDissociation
* bindingConstraintHour
* ghost
* this is not only about constraint builder
* pay attention to the time step
* specific issue
* bug free
* smooth green?
* M&M
* Max Pumping ok?
* Area Hydro Level (_-_)
* finally
* basic
* tiny
* clean code
* add {PMin,PMax}DispatchableGeneration
* clean code
* ConsistenceNODU ok
* NbUnitsOutageLessThanNbUnitsStop
* NbDispUnitsMinBoundSinceMinUpTime
* MinDownTime
* setup Access Control
* remove comments
* remove comments
* treat major code smells
* treat major code smells 2
* more on major code smells
* update after review
* about objects lifetime
* (does not compile) cut into small pieces
* Revert "(does not compile) cut into small pieces"
This reverts commit 5a047c0.
* aesthetic
* remove comment
* smart move
* **** move
* shallow
* customize error exception
* test new variable construction design
* refactor
* update build for NODU
* clean deprecated code
* update build for NumberStoppingDispatchableUnits
* on NumberStartingDispatchableUnits
* on NumberBreakingDownDispatchableUnits
* new build NTCDirect
* missing file NTCDirect
* Interco Direct/Indirect Cost
* ShortTermStorageInjection
* ShortTermStorageWithdrawal
* ShortTermStorageLevel
* HydProd
* HydProdDown
* HydProdUp
* Pumping
* HydroLevel
* Overflow
* FinalStorage
* fix
* LayerStorage
* Psitive/Negative UnsuppliedEnergy
* remove old code
* remove code
* fix
* move
* clarity matters thanks to @sylvlecl
* There is no need for repetition
* it makes sense: Constraint->ConstraintFactory
* update
* remove redundant check
* rename things
* unused
* debug
* fiiiiiiiix
* add explicit keyword
* inspect unique_ptr
* resolve conflicts
* quick fix
* suggestion by @flomnes
Co-authored-by: Florian Omnès <[email protected]>
* add docs
* docs for new constraint classes
* update
* complete new classes documentation
* update
* update
* small changes
* small changes 2
* remove comment
* default value for constraint op
* clean code
* smell code
* smell code
* fix
* pretty
* typo
---------
Co-authored-by: Florian Omnès <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this follows on from the work on #1234 #1605