Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for problem naming #1611

Merged

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Sep 5, 2023

TODO : replace bool in PROBLEME_SIMPLEXE_NOMME by std::unique_ptr<NameTranslator>

@flomnes flomnes requested a review from a-zakir September 5, 2023 14:54
@flomnes flomnes marked this pull request as draft September 5, 2023 14:54
std::transform(src.begin(),
src.end(),
std::back_inserter(pointerVec),
[](const std::string& str) { return str.empty() ? nullptr : const_cast<char*>(str.data()); });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const_cast was moved here

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@flomnes flomnes marked this pull request as ready for review September 11, 2023 12:56
@flomnes flomnes merged commit d9a7a70 into fix/infeasible-problems-analyzer Sep 11, 2023
@flomnes flomnes deleted the fix/interface-problem-naming branch September 11, 2023 12:57
flomnes added a commit that referenced this pull request Sep 14, 2023
* update constraint pattern

* fix prettyprint of suspicious constraints

* parse time step

* update regex

* always name antares problems

* named problems with unnamed mps

* refacto ortools utils

* enable naming for the analyzer

* format

* format  code

* refactor: Create ProblemSimplexeNommeConverter

* continuing refacto

* fix missing constaints names

* const_cast to avoid unnecessary copy of vector<string>

* Add interface for problem naming (#1611)

* Add interface for problem naming

* Add missing header

* secure

* tiny

---------

Co-authored-by: Florian Omnès <florian.omnes@rte-france.com>
Co-authored-by: Abdoulbari ZAKIR <azakir@neverhack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants