Fix/global var hydro modulable

[guilpier-code]

Before the current pull request, type VAL_GEN_PAR_PAYS contained only data members related to hydro, and even hydro made available by hydro ventilation.

• Moving VAL_GEN_PAR_PAYS valeursGenereesParPays from class ISimulation into class HydroManagement, and renaming it ALL_HYDRO_VENTILATION_RESULTS ventilationResults.
• Cleaning the class HydroManagement :
  • Removing dependency to Study, replaced with dependencies to AreaList, Parameters, Calendar, ...
  • Renaming operator () (...) into makeVentilation(...), much more clear

[sonarqubecloud]

SonarCloud Quality Gate failed.   

3 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

0.0% Coverage
0.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[flomnes]

Suggested change

	void makeVentilation(double* randomReservoirLevel,
	Solver::Variable::State& state,
	uint y,
	uint numSpace);
	ALL_HYDRO_VENTILATION_RESULTS makeVentilation(double* randomReservoirLevel,
	Solver::Variable::State& state,
	uint y,
	uint numSpace);

One single method instead of two.

[guilpier-code]

ok. So this means that we could simplify the caller too :

// solver.hxx
yearFailed[y] = !simulation_->year(...,
                                   ...,
                                   simulation_->hydroManagement.makeVentilation(/* some args */));

As a consequence, we would skip calls the timer / add duration, unless we put these calls in the HydroManagement :: makeVentilation.
What do you recommend ?

[flomnes]

I think we should keep the timer, but have a single function.

// Timer ON
auto hydroVentilation = simulation_->hydroManagement.makeVentilation(/* args */);
// Timer OFF
yearFailed[y] = !simulation_->year(...,
                                   ...,
                                   hydroVentilation);