Remove global var NumeroChroniquesTireesParPays #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
flomnes
approved these changes
Sep 12, 2023
flomnes
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Global vars - try remove HydrauliqueModulableQuotidien : simple renaming * Global vars - try remove HydrauliqueModulableQuotidien : cleaning n class HydroManagement * Global vars : rename and move down struct VALEURS_GENEREES_PAR_PAYS * [skip ci] Global vars : small simplification * remove TS number global var : we don't need timeseriesNumberYear in StudyRuntimeInfos (#1618) * [skip ci] remove TS number global var : correction after review
flomnes
added a commit
that referenced
this pull request
Sep 19, 2023
* [skip ci] Remove global vars : a bit of cleaning * Remove global vars : valeursGenereesParPays's allocation moved in a constructor + simplifying runtime * Remove global vars : unnecessary initialization of HydrauliqueModulableQuotidien (already done in simulation) * Remove global vars : remove unnecessary function, as it only calls one other function * Remove global vars : back to previous state, before wrong correction * Remove global vars : a bit of clarification in ALEA_TirageAuSortChroniques * Remove global vars : renaming * Remove global vars : simplifying and clarifying a bit thermal noises * Remove global vars : moving thermal noises to where it belongs + removing the useless AleaCoutDeProductionParPalier * Remove global vars : forgot to update adequacy mode with the new way we add thermal noise * Remove global vars : regression fix * Remove global vars : extract thermal part of weekly problem building, because of adq patch * [skip ci] Remove global vars : just clarifying * Remove global vars : remove call to SIM_RenseignementProblemeHebdo in AdequacyPatchOptimization::solve * Remove global vars : after previous commit removal, simplifications come naturally * Remove global vars : some cleaning * Fix/global var hydro modulable (#1614) * Global vars - try remove HydrauliqueModulableQuotidien : simple renaming * Global vars - try remove HydrauliqueModulableQuotidien : cleaning n class HydroManagement * Global vars : rename and move down struct VALEURS_GENEREES_PAR_PAYS * [skip ci] Global vars : small simplification * remove TS number global var : we don't need timeseriesNumberYear in StudyRuntimeInfos (#1618) * [skip ci] remove TS number global var : correction after review * Update src/libs/antares/study/area/scratchpad.cpp Co-authored-by: abdoulbari zakir <[email protected]> * Apply a-zakir's remark * Remove unused argument from StudyRuntimeInfos's ctor (#1634) --------- Co-authored-by: Florian Omnès <[email protected]> Co-authored-by: abdoulbari zakir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.