Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove malloc in src/solver/hydro/ #1626

Merged
merged 43 commits into from
Sep 25, 2023
Merged

Remove malloc in src/solver/hydro/ #1626

merged 43 commits into from
Sep 25, 2023

Conversation

payetvin
Copy link
Contributor

issue #1575
previous PR: #1620

@payetvin payetvin self-assigned this Sep 15, 2023
@payetvin payetvin force-pushed the fix/upgrade-solver-hydro-final branch from 089a1fe to 170f915 Compare September 15, 2023 15:12
flomnes
flomnes requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change required is now Flag

@payetvin payetvin force-pushed the fix/upgrade-solver-hydro-final branch from 1157ea5 to c4dd148 Compare September 21, 2023 13:19
@flomnes
Copy link
Member

flomnes commented Sep 21, 2023

@payetvin Please resolve conflicts

flomnes
flomnes requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use std::unique_ptr or std::shared_ptr instead of new / delete
  • You forgot this malloc
    File: daily2/h2o2_j_resoudre_le_probleme_lineaire.cpp
    77:40: Probleme = (PROBLEME_SIMPLEXE*)malloc(sizeof(PROBLEME_SIMPLEXE));

flomnes
flomnes requested changes Sep 22, 2023
View reviewed changes
src/solver/hydro/management/daily.cpp Outdated Show resolved Hide resolved
src/solver/hydro/management/daily.cpp Outdated Show resolved Hide resolved
src/solver/hydro/monthly/h2o_m_free.cpp Outdated Show resolved Hide resolved
src/solver/hydro/monthly/h2o_m_resoudre_le_probleme_lineaire.cpp Outdated Show resolved Hide resolved
@payetvin payetvin requested a review from flomnes September 25, 2023 08:07
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
5.1% 5.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@flomnes flomnes merged commit bf54e4e into develop Sep 25, 2023
6 of 7 checks passed
@flomnes flomnes deleted the fix/upgrade-solver-hydro-final branch September 25, 2023 17:18
a-zakir pushed a commit that referenced this pull request Oct 2, 2023
@payetvin @a-zakir
Remove malloc in src/solver/hydro/ (#1626)
0176d5a
@a-zakir a-zakir restored the fix/upgrade-solver-hydro-final branch October 4, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees

@payetvin payetvin

Labels
cleaning code quality size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@payetvin @flomnes