Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Antares::action" CMake library, build only if BUILD_UI=ON #1637

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Add "Antares::action" CMake library, build only if BUILD_UI=ON #1637

merged 5 commits into from
Sep 20, 2023

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Sep 19, 2023 •
edited
Loading

Some libraries in libs/antares/study are only used by the GUI executable.

So there is no need to build them if BUILD_UI=OFF.

Reflect this dependency in the CMake build system.

This should speed-up the build a bit when BUILD_UI=OFF.

@flomnes flomnes linked an issue Sep 19, 2023 that may be closed by this pull request
Build action/handler/antares-study only if BUILD_UI=ON #1636
Closed
@flomnes flomnes requested a review from sylvlecl September 19, 2023 16:39
@flomnes flomnes added enhancement New feature or request build labels Sep 19, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 43 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 306 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sylvlecl
sylvlecl approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we could also completely move it to the UI directory, but it may involve more work?

@sylvlecl sylvlecl merged commit fbaa325 into develop Sep 20, 2023
6 of 7 checks passed
@sylvlecl sylvlecl deleted the fix/add-action-library branch September 20, 2023 12:17
@flomnes
Copy link
Member Author

flomnes commented Sep 20, 2023

Note that we could also completely move it to the UI directory, but it may involve more work?

That's what I did in a 2nd part. And yes, it took some work fixing headers, making some public, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvlecl sylvlecl sylvlecl approved these changes

Assignees
No one assigned
Labels
build enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build action/handler/antares-study only if BUILD_UI=ON
2 participants
@flomnes @sylvlecl