Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong year number in logs upon failed year #1672

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Oct 3, 2023

Inconsistent year numbers are displayed because different conventions are used for year indexing. The developer indexing starts from 0, while user indexing starts at 1.

Log extract before

[2023-10-03 20:32:11][solver][infos] Year(s) 14 
[2023-10-03 20:32:11][solver][fatal] Year 13 has failed in the previous set of parallel year.

Log extract after

[2023-10-03 20:32:11][solver][infos] Year(s) 14 
[2023-10-03 20:32:11][solver][fatal] Year 14 has failed in the previous set of parallel year.

@flomnes flomnes added the bug Something isn't working label Oct 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@flomnes flomnes merged commit ab96d29 into develop Oct 4, 2023
7 checks passed
@flomnes flomnes deleted the fix/incorrect-year-number-failed-year branch October 4, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants