Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output variable profit #1767

Merged
merged 12 commits into from
Nov 20, 2023
Merged

Fix output variable profit #1767

merged 12 commits into from
Nov 20, 2023

Conversation

payetvin
Copy link
Contributor

close #1753

@payetvin payetvin added the bug Something isn't working label Nov 13, 2023
@payetvin payetvin requested a review from flomnes November 13, 2023 14:54
@payetvin payetvin self-assigned this Nov 13, 2023
flomnes
flomnes requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in parallel execution since ThermalCluster::pMin is shared across threads. More specifically, multiple threads read/write the same memory block, possibly leading to different results sequential vs parallel.

@flomnes
Copy link
Member

flomnes commented Nov 17, 2023

We should probably re-generate some reference results, after checking that the changes are as expected.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@flomnes flomnes merged commit 121f947 into develop Nov 20, 2023
5 of 7 checks passed
@flomnes flomnes deleted the fix/profit branch November 20, 2023 12:32
flomnes added a commit that referenced this pull request Nov 21, 2023
@flomnes
Fix output variable PROFIT for thermal clusters (#1767)
a03a912 
* [DEV] Set thetaInf value to match constraint value

* [DEV] Revert thetainf changes

* [DEV] Add pmin to thermal cluster

* [DEV] Add pmin to resultatsHoraires

* [DEV] Add move pmin to PRODUCTION_THERMIQUE_OPTIMAL

* [DEV] Use PuissanceMinDuPalierThermique

* [DEV] Check if PuissanceDisponibleEtCout is empty

* [DEV] if syntax

* [DEV] use PMinOfClusters

* [DEV] Clean comments

* [DEV] use PuissanceMinDuPalierThermique

* Revert "[DEV] use PuissanceMinDuPalierThermique"

This reverts commit 8580847.

---------

Co-authored-by: Florian OMNES <[email protected]>
flomnes added a commit that referenced this pull request Nov 21, 2023
@flomnes
Fix output variable PROFIT for thermal clusters (#1767)
6b0ec1a 
* [DEV] Set thetaInf value to match constraint value

* [DEV] Revert thetainf changes

* [DEV] Add pmin to thermal cluster

* [DEV] Add pmin to resultatsHoraires

* [DEV] Add move pmin to PRODUCTION_THERMIQUE_OPTIMAL

* [DEV] Use PuissanceMinDuPalierThermique

* [DEV] Check if PuissanceDisponibleEtCout is empty

* [DEV] if syntax

* [DEV] use PMinOfClusters

* [DEV] Clean comments

* [DEV] use PuissanceMinDuPalierThermique

* Revert "[DEV] use PuissanceMinDuPalierThermique"

This reverts commit 8580847.

---------

Co-authored-by: Florian OMNES <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees

@payetvin payetvin

Labels
bug Something isn't working size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid values for output variable PROFIT
2 participants
@payetvin @flomnes