-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output variable profit #1767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work in parallel execution since ThermalCluster::pMin
is shared across threads. More specifically, multiple threads read/write the same memory block, possibly leading to different results sequential vs parallel.
We should probably re-generate some reference results, after checking that the changes are as expected. |
This reverts commit 8580847.
Kudos, SonarCloud Quality Gate passed! |
* [DEV] Set thetaInf value to match constraint value * [DEV] Revert thetainf changes * [DEV] Add pmin to thermal cluster * [DEV] Add pmin to resultatsHoraires * [DEV] Add move pmin to PRODUCTION_THERMIQUE_OPTIMAL * [DEV] Use PuissanceMinDuPalierThermique * [DEV] Check if PuissanceDisponibleEtCout is empty * [DEV] if syntax * [DEV] use PMinOfClusters * [DEV] Clean comments * [DEV] use PuissanceMinDuPalierThermique * Revert "[DEV] use PuissanceMinDuPalierThermique" This reverts commit 8580847. --------- Co-authored-by: Florian OMNES <[email protected]>
* [DEV] Set thetaInf value to match constraint value * [DEV] Revert thetainf changes * [DEV] Add pmin to thermal cluster * [DEV] Add pmin to resultatsHoraires * [DEV] Add move pmin to PRODUCTION_THERMIQUE_OPTIMAL * [DEV] Use PuissanceMinDuPalierThermique * [DEV] Check if PuissanceDisponibleEtCout is empty * [DEV] if syntax * [DEV] use PMinOfClusters * [DEV] Clean comments * [DEV] use PuissanceMinDuPalierThermique * Revert "[DEV] use PuissanceMinDuPalierThermique" This reverts commit 8580847. --------- Co-authored-by: Florian OMNES <[email protected]>
close #1753