Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang warnings #1776

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Fix clang warnings #1776

merged 3 commits into from
Nov 17, 2023

Conversation

JasonMarechal25
Copy link
Contributor

  • several unused parameters
  • Adding virtual destructor when expected

And a few other

@@ -470,7 +470,7 @@ typename Grid<NodeT>::VectorEdgeP Grid<NodeT>::findShortestPath(NodeP node1, Nod
Grid::VectorEdgeP path;
Grid::NodeP currentNode = node2;

while (!prev[currentNode] == 0)
while (!(prev[currentNode] == 0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
while (!(prev[currentNode] == 0))
while ((!prev[currentNode]) == 0)

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

47.8% 47.8% Coverage
0.0% 0.0% Duplication

@flomnes flomnes merged commit 4c9b101 into develop Nov 17, 2023
7 checks passed
@flomnes flomnes deleted the feature/clang-warnings branch November 17, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants