Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to release without running any tests #1852

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Dec 27, 2023

This is useful for releases where we know results will deviate from reference results.

Currently

Workflow when results change

  1. Disable tests by commenting them in the YML workflows
  2. Create a RC release
  3. Generate new reference results
  4. Uncomment tests in YML workflows
  5. Create a definitive release with tests

Workflow when results don't change

  1. Generate new release with tests

After

Workflow when results change

  1. Create release without running the tests
  2. Create a RC release
  3. Generate new reference results
  4. Generate definitive release with tests

We save two steps (comment/uncomment).

Workflow when results don't change

  1. Generate new release with tests

Note

It won't be possible to manually create a new release, all releases will have to be created using the new_release.yml workflow. This is because the condition for asset upload changes from ${{ github.event_name == 'release' && github.event.action == 'created' }} to ${{ github.event_name == 'workflow_call' }}.

Reference

https://docs.github.com/en/actions/using-workflows/reusing-workflows
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_callinputsinput_idtype

Copy link

watermelon-copilot-for-code-review bot commented Dec 27, 2023

Watermelon AI Summary

AI Summary deactivated by flomnes

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

@flomnes flomnes merged commit b217f36 into develop Dec 29, 2023
4 checks passed
@flomnes flomnes deleted the feature/manual-release branch December 29, 2023 13:46
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants