Use std::unordered_map for tmpDataByArea_ (hydro ventilation)

[flomnes]

Why ?

Using a std::vector requires one 2 indirections area -> index -> tmpData

Using a std::unordered_map, we don't need to worry about indices anymore, we can just get area -> tmpData.

NOTES

• The AreaList shall never be resized after assigning the newly created map. Otherwise pointers used as keys would be invalid. This works because no areas are added/removed after loading a study.
• Replacing a std::vector by a std::unordered_map works because we don't rely on order. If we did, using pointers as map keys would produce unpredictable results.

[watermelon-copilot-for-code-review]

Watermelon AI Summary

AI Summary deactivated by flomnes

GitHub PRs

• #1855 - Use std::unordered_map for tmpDataByArea_ (hydro ventilation) - By flomnes 1 hours ago

• #1843 - hydro max power : adding unit tests - By guilpier-code 1 weeks ago

• #1723 - Multiple Maximum Generation and Pumping for Hydro (Merging with develop branch) - By nikolaredstork 2 months ago

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud