-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to solver : trial for simplification #2452
Draft
guilpier-code
wants to merge
16
commits into
develop
Choose a base branch
from
fix/call-to-solver-simplified
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
54d88cb
Remove Sirius direct call : all developments in one
guilpier-code 4fb3544
Remove Sirius direct call : more tests on CI
guilpier-code 1bb4a6c
Remove Sirius direct call : clang format
guilpier-code 8b5f1cc
Remove Sirius direct call : cucumber is adapted to current changes (C…
guilpier-code 27fc92e
Trial to simplify solver call : solver ptr a bit more clear
guilpier-code a4f1d80
Trial to simplify solver call : crash correction
guilpier-code c8d5896
Trial to simplify solver call : omission in previous commit corrected
guilpier-code 343f2d8
Trial to simplify solver call : correct a crash on infeasible problems
guilpier-code 91de738
Trial to simplify solver call : try to improve solver liberation
guilpier-code ef66d4c
Trial to simplify solver call : towards more improvement on solver li…
guilpier-code 59348c7
Trial to simplify solver call : improve solvers passing among all run…
guilpier-code e36b6dd
Trial to simplify solver call : avoid code duplication in resetting s…
guilpier-code c2ab575
Trial to simplify solver call : no need to import basic status into c…
guilpier-code 1b4ebd0
Trial to simplify solver call : for solver, case SPX_ERREUR_INTERNE i…
guilpier-code 15851b6
Trial to simplify solver call : trial to remove status transfers betw…
guilpier-code 668ce02
[skip ci] Revert "Trial to simplify solver call : trial to remove sta…
guilpier-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Trial to simplify solver call : for solver, case SPX_ERREUR_INTERNE i…
…s impossible
commit 1b4ebd08e68b1bb0416b9611b16bd38ccd503441
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to test
ExistenceDUneSolution != SPX_ERREUR_INTERNE
.But
ExistenceDUneSolution == SPX_ERREUR_INTERNE
is impossible : indeed, ExistenceDUneSolution is given by ortools now, which does not know value SPX_ERREUR_INTERNE.