Using filesystem path 2 [ANT-1999] #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torTeam/Antares_Simulator into feature/use-std-fs
flomnes
requested changes
Oct 14, 2024
Comment on lines
-181
to
-191
| template<class StringT> | ||
| size_t sizeOnDisk(const StringT& sourceFolder) const | ||
| { | ||
| if (item.empty()) | ||
| { | ||
| return 0; | ||
| } | ||
| pTmp = sourceFolder; | ||
| return (!pTmp) ? 0 : internalSizeOnDisk(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Note to other readers: this function is unused
Comment on lines
-44
to
-60
| size_t PathList::internalSizeOnDisk() const | ||
| { | ||
| size_t size = 0; | ||
| Clob buffer; | ||
|
|
||
| const ItemList::const_iterator end = item.end(); | ||
| for (ItemList::const_iterator i = item.begin(); i != end; ++i) | ||
| { | ||
| if (!(i->second.options & pathListOptFolder)) | ||
| { | ||
| buffer.clear() << pTmp << SEP << i->first; | ||
| size += (size_t)IO::File::Size(pTmp); | ||
| } | ||
| } | ||
| return size; | ||
| } | ||
|
|
src/libs/antares/study/include/antares/study/parts/solar/prepro.h
Outdated
Show resolved
Hide resolved
| @@ -254,7 +251,7 @@ void List<NextT>::buildSurveyReport(SurveyResults& results, | |||
|
|
|||
| // The new filename | |||
| results.data.filename.clear(); | |||
| results.data.filename << results.data.output << SEP; | |||
| results.data.filename << std::filesystem::path(std::string(results.data.output)) / ""; | |||
There was a problem hiding this comment.
I agree, but it avoids intermediate variables needed to convert from yuni string
Comment on lines
+360
to
+361
| path /= std::filesystem::path("areas") / area.id.to<std::string>() / "thermal" | ||
| / cluster->id(); |
There was a problem hiding this comment.
If you have a typedef, you can just use
Suggested change
| path /= std::filesystem::path("areas") / area.id.to<std::string>() / "thermal" | |
| / cluster->id(); | |
| path /= fs("areas") / area.id.to<std::string>() / "thermal" | |
| / cluster->id(); |
There was a problem hiding this comment.
It's a hxx file, i don't use typedef
flomnes
approved these changes
Oct 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #2435