-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modeler 4.4: expression parsing [ANT-2313] #2471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payetvin
changed the title
Modeler 4.4: expression parsing
Modeler 4.4: expression parsing [ANT-2313]
Oct 23, 2024
a-zakir
reviewed
Oct 23, 2024
add antlr4 here |
guilpier-code
previously requested changes
Nov 20, 2024
src/solver/modelConverter/include/antares/solver/modelConverter/convertorVisitor.h
Outdated
Show resolved
Hide resolved
src/solver/libModelObject/include/antares/solver/libObjectModel/expression.h
Outdated
Show resolved
Hide resolved
flomnes
approved these changes
Nov 25, 2024
pet-mit
approved these changes
Nov 25, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements to the ANTLR grammar and related files for the
Expr
language. The changes involve modifications to the grammar rules, updates to the CMake configuration, and synchronization with a newer version of ANTLR.Grammar and Parsing Improvements:
Expr.g4
grammar to introduce new rules and improve parsing capabilities, including the addition ofatom
,shift_expr
, andright_expr
rules. [1] [2]Expr.tokens
to reflect new token definitions and changes in the grammar.Expr.g4
andExpr.tokens
. [1] [2]Build Configuration Updates:
sonar-project.properties
to excludesrc/libs/antares/antlr-interface
from Sonar analysis. antlr-interface contains generated code that trigger defect in analysisCMakeLists.txt
to always include theantlr-interface
directory and removed conditional logic for building with ANTLR4. [1] [2] [3]Synchronization with ANTLR 4.13.2:
ExprBaseVisitor.cpp
,ExprBaseVisitor.h
, andExprLexer.cpp
. [1] [2] [3]ExprLexer.cpp
to usestd::unique_ptr
for static data initialization. [1] [2]Visitor Pattern Enhancements:
ExprBaseVisitor
to include new visit methods for the added grammar rules. [1] [2]These changes collectively enhance the flexibility and maintainability of the grammar and build configuration, while ensuring compatibility with the latest ANTLR version.